fix(ai-chat): send the done frame after the transcript is persisted by threepointone · Pull Request #2334 · cloudflare/agents

threepointone · 2026-09-23T14:38:00Z

Problem

useAgentChat switches to ready when it receives the terminal done frame, and a later cf_agent_chat_messages snapshot replaces the client's message list. AIChatAgent sent done from its stream helpers, before _reply persisted the assistant message and broadcast the transcript. A message the user sent right after the reply finished could therefore be wiped by the late snapshot until the next turn.

This is the same ordering bug Think had in #2119 (fixed in #2327), but narrower. On a normal WebSocket turn, the sending connection is excluded from its own transcript broadcast, so it is not affected. These cases are affected:

Programmatic turns (saveMessages(), scheduled work, continuations), whose transcript goes to every connection.
Other tabs watching someone else's turn.

Fix

 stream finishes
- send done → persist → broadcast transcript
+ persist → broadcast transcript → send done

Terminal frames are sent from about six places: the SSE and plain-text helpers, the in-band error chunk, the stall routes, and the error path. So instead of threading a held frame through each one, _broadcastChatMessage holds the terminal done frame for a request while _reply owns it, and _reply releases it after the persist.
If persisting fails, the held frame is released as an error frame, so a client never sees a successful done for a reply that was not saved.
design/chat-shared-layer.md records the ordering rule.

Validation:

New terminal-frame-order.test.ts covers the transcript arriving before done for SSE and plain-text replies seen from another tab, for a stream that throws mid-reply (the partial arrives before the error frame), and for a programmatic saveMessages() turn, plus the error frame when persisting fails. All five fail without the fix.
The full ai-chat suite (740 tests) and pnpm run check passed.

Follow-up to #2119. Independent of the Think stack in #2322 through #2331.

changeset-bot · 2026-09-23T14:38:06Z

🦋 Changeset detected

Latest commit: 39dff48

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages

Name	Type
@cloudflare/ai-chat	Patch
@cloudflare/agent-think	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

agent-think · 2026-09-23T14:40:30Z

⚪ agents import sizes

Measured 343 runtime imports as minified bundles. The primary size is gzip; raw minified size is included for diagnosis. An existing import growing by more than 10% is marked red. This report is informational.

Red	Yellow	Green	Unchanged	New	Removed
0	0	0	343	0	0

Compared 7d58ade0 with a56a8d77. Open workflow run.

No import sizes changed.

All 343 current runtime imports

Status	Import	Gzip	Raw minified
⚪	`agents#__DO_NOT_USE_WILL_BREAK__agentContext`	261.1 KiB	1141.0 KiB
⚪	`agents#__DO_NOT_USE_WILL_BREAK__withInvocationScope`	261.1 KiB	1141.0 KiB
⚪	`agents#Agent`	261.1 KiB	1141.0 KiB
⚪	`agents#AGENT_TOOL_MILESTONE_PART`	261.1 KiB	1141.0 KiB
⚪	`agents#AGENT_TOOL_PROGRESS_PART`	261.1 KiB	1141.0 KiB
⚪	`agents#buildAgentPath`	261.7 KiB	1143.3 KiB
⚪	`agents#buildAgentUrl`	261.8 KiB	1143.7 KiB
⚪	`agents#callable`	261.1 KiB	1141.0 KiB
⚪	`agents#camelCaseToKebabCase`	261.1 KiB	1141.0 KiB
⚪	`agents#createHeaderBasedEmailResolver`	261.3 KiB	1141.4 KiB
⚪	`agents#DEFAULT_AGENT_STATIC_OPTIONS`	261.1 KiB	1141.0 KiB
⚪	`agents#DurableObjectOAuthClientProvider`	261.1 KiB	1141.0 KiB
⚪	`agents#getAgentByName`	261.1 KiB	1141.0 KiB
⚪	`agents#getCurrentAgent`	261.1 KiB	1141.0 KiB
⚪	`agents#getSubAgentByName`	261.4 KiB	1141.6 KiB
⚪	`agents#isDurableObjectCodeUpdateReset`	261.1 KiB	1141.0 KiB
⚪	`agents#isDurableObjectMemoryLimitReset`	261.1 KiB	1141.0 KiB
⚪	`agents#isDurableObjectStorageReset`	261.1 KiB	1141.0 KiB
⚪	`agents#isPlatformTransientError`	261.1 KiB	1141.0 KiB
⚪	`agents#MCP_SERVER_ID_MAX_LENGTH`	261.1 KiB	1141.0 KiB
⚪	`agents#MessageType`	261.2 KiB	1141.3 KiB
⚪	`agents#normalizeServerId`	261.1 KiB	1141.0 KiB
⚪	`agents#parseSubAgentPath`	261.1 KiB	1141.0 KiB
⚪	`agents#routeAgentEmail`	261.4 KiB	1141.7 KiB
⚪	`agents#routeAgentRequest`	261.7 KiB	1142.9 KiB
⚪	`agents#routeSubAgentRequest`	261.3 KiB	1141.5 KiB
⚪	`agents#SqlError`	261.1 KiB	1141.0 KiB
⚪	`agents#StreamingResponse`	261.1 KiB	1141.0 KiB
⚪	`agents#SUB_PREFIX`	261.1 KiB	1141.0 KiB
⚪	`agents#unstable_callable`	261.2 KiB	1141.2 KiB
⚪	`agents/agent-tools#agentTool`	112.5 KiB	538.2 KiB
⚪	`agents/browser#BrowserConnector`	50.5 KiB	176.6 KiB
⚪	`agents/browser#browserContent`	36.3 KiB	127.4 KiB
⚪	`agents/browser#browserExtract`	36.3 KiB	127.4 KiB
⚪	`agents/browser#browserLinks`	36.3 KiB	127.4 KiB
⚪	`agents/browser#browserMarkdown`	36.3 KiB	127.4 KiB
⚪	`agents/browser#browserPdf`	36.3 KiB	127.3 KiB
⚪	`agents/browser#BrowserRenderingError`	36.0 KiB	126.7 KiB
⚪	`agents/browser#browserScrape`	36.3 KiB	127.4 KiB
⚪	`agents/browser#browserScreenshot`	36.3 KiB	127.3 KiB
⚪	`agents/browser#browserSnapshot`	36.3 KiB	127.4 KiB
⚪	`agents/browser#CdpSession`	37.2 KiB	129.8 KiB
⚪	`agents/browser#CodemodeRuntime`	39.6 KiB	139.0 KiB
⚪	`agents/browser#connectBrowser`	37.8 KiB	131.4 KiB
⚪	`agents/browser#connectBrowserSession`	37.5 KiB	130.4 KiB
⚪	`agents/browser#connectUrl`	37.6 KiB	130.5 KiB
⚪	`agents/browser#createBrowserSession`	36.3 KiB	127.5 KiB
⚪	`agents/browser#DEFAULT_EXEC_SWEEP_IDLE_MS`	36.0 KiB	126.6 KiB
⚪	`agents/browser#DEFAULT_SWEEP_IDLE_MS`	36.0 KiB	126.6 KiB
⚪	`agents/browser#deleteBrowserSession`	36.1 KiB	126.9 KiB
⚪	`agents/browser#DurableBrowserSessionStore`	36.4 KiB	127.6 KiB
⚪	`agents/browser#getBrowserRecording`	36.2 KiB	127.1 KiB
⚪	`agents/browser#listBrowserTargets`	36.1 KiB	126.9 KiB
⚪	`agents/browser#loadCdpSpec`	36.6 KiB	128.3 KiB
⚪	`agents/browser#runQuickAction`	36.0 KiB	126.6 KiB
⚪	`agents/browser/ai#createBrowserRuntime`	147.0 KiB	632.8 KiB
⚪	`agents/browser/ai#createBrowserTools`	147.0 KiB	632.9 KiB
⚪	`agents/browser/ai#createQuickActionTools`	122.5 KiB	554.3 KiB
⚪	`agents/browser/tanstack-ai#createBrowserTools`	162.7 KiB	701.7 KiB
⚪	`agents/channels#ChannelHost`	3.3 KiB	9.1 KiB
⚪	`agents/channels#consumeChunks`	237 B	321 B
⚪	`agents/channels#createUserIdentityStore`	1.3 KiB	3.2 KiB
⚪	`agents/channels#fallback`	155 B	160 B
⚪	`agents/channels#fallbackChannel`	893 B	1.9 KiB
⚪	`agents/channels#fanout`	151 B	156 B
⚪	`agents/channels#fanoutChannel`	875 B	1.9 KiB
⚪	`agents/channels#identityKey`	178 B	223 B
⚪	`agents/channels#isChannelMessageSurface`	271 B	452 B
⚪	`agents/channels#linkChannelIdentities`	113 B	99 B
⚪	`agents/channels#matchesPath`	110 B	96 B
⚪	`agents/channels#routes`	307 B	507 B
⚪	`agents/channels#UserIdentityConflictError`	248 B	335 B
⚪	`agents/channels/ai-sdk#createSendMessageTool`	112.2 KiB	537.4 KiB
⚪	`agents/channels/ai-sdk#toChannelChunks`	112.5 KiB	538.4 KiB
⚪	`agents/channels/email#email`	23.5 KiB	75.4 KiB
⚪	`agents/channels/email#inboundEmail`	22.3 KiB	72.3 KiB
⚪	`agents/channels/slack#slack`	5.5 KiB	14.6 KiB
⚪	`agents/channels/slack#slackWebhook`	2.2 KiB	5.1 KiB
⚪	`agents/channels/tanstack-ai#createSendMessageTool`	16.2 KiB	68.4 KiB
⚪	`agents/channels/telegram#telegram`	3.8 KiB	10.3 KiB
⚪	`agents/channels/telegram#telegramWebhook`	1.6 KiB	3.6 KiB
⚪	`agents/channels/voice#browserVoice`	1010 B	2.2 KiB
⚪	`agents/chat#AbortRegistry`	2.5 KiB	8.9 KiB
⚪	`agents/chat#AGENT_TOOL_STREAM_PROGRESS_BUMP_THROTTLE_MS`	2.3 KiB	8.2 KiB
⚪	`agents/chat#AgentToolProgressEmitter`	2.7 KiB	9.5 KiB
⚪	`agents/chat#AgentToolStreamProgressThrottle`	2.4 KiB	8.3 KiB
⚪	`agents/chat#aiSdkRecoveryCodec`	2.3 KiB	8.2 KiB
⚪	`agents/chat#applyAgentToolEvent`	3.2 KiB	11.0 KiB
⚪	`agents/chat#applyChunkToParts`	2.3 KiB	8.2 KiB
⚪	`agents/chat#applyToolUpdate`	2.4 KiB	8.4 KiB
⚪	`agents/chat#AutoContinuationController`	2.3 KiB	8.2 KiB
⚪	`agents/chat#awaitWithDeadline`	2.4 KiB	8.4 KiB
⚪	`agents/chat#broadcastTransition`	3.2 KiB	11.4 KiB
⚪	`agents/chat#buildChatRecoveringFrame`	2.4 KiB	8.4 KiB
⚪	`agents/chat#buildInClauseStrings`	2.4 KiB	8.4 KiB
⚪	`agents/chat#bumpChatRecoveryProgress`	2.4 KiB	8.3 KiB
⚪	`agents/chat#byteLength`	2.5 KiB	8.5 KiB
⚪	`agents/chat#CHAT_LAST_TERMINAL_KEY`	2.3 KiB	8.2 KiB
⚪	`agents/chat#CHAT_MESSAGE_TYPES`	2.3 KiB	8.2 KiB
⚪	`agents/chat#CHAT_RECOVERING_FLAG_TTL_MS`	2.3 KiB	8.2 KiB
⚪	`agents/chat#CHAT_RECOVERING_KEY`	2.3 KiB	8.2 KiB
⚪	`agents/chat#CHAT_RECOVERY_ALARM_DEBOUNCE_MS`	2.3 KiB	8.2 KiB
⚪	`agents/chat#CHAT_RECOVERY_INCIDENT_KEY_PREFIX`	2.3 KiB	8.2 KiB
⚪	`agents/chat#CHAT_RECOVERY_INCIDENT_TTL_MS`	2.3 KiB	8.2 KiB
⚪	`agents/chat#CHAT_RECOVERY_PROGRESS_KEY`	2.3 KiB	8.2 KiB
⚪	`agents/chat#CHAT_RECOVERY_STABLE_RETRY_DELAY_SECONDS`	2.3 KiB	8.2 KiB
⚪	`agents/chat#CHAT_RECOVERY_TASK_NAME`	2.3 KiB	8.2 KiB
⚪	`agents/chat#CHAT_STREAM_PROGRESS_CREDIT_THROTTLE_MS`	2.3 KiB	8.2 KiB
⚪	`agents/chat#ChatRecoveryEngine`	4.4 KiB	15.3 KiB
⚪	`agents/chat#chatRecoveryTaskRunOptions`	2.4 KiB	8.6 KiB
⚪	`agents/chat#ChatStreamStalledError`	2.4 KiB	8.3 KiB
⚪	`agents/chat#classifyAgentToolChildRecovery`	2.4 KiB	8.5 KiB
⚪	`agents/chat#clearChatTerminal`	2.3 KiB	8.3 KiB
⚪	`agents/chat#clientResolvableToolNames`	2.3 KiB	8.3 KiB
⚪	`agents/chat#ContinuationState`	2.7 KiB	9.8 KiB
⚪	`agents/chat#createAgentToolEventState`	2.3 KiB	8.3 KiB
⚪	`agents/chat#createChatFiberSnapshot`	2.5 KiB	8.6 KiB
⚪	`agents/chat#createChatRecoveryTaskDefinition`	2.6 KiB	9.0 KiB
⚪	`agents/chat#createChatStreams`	6.4 KiB	22.1 KiB
⚪	`agents/chat#createChatTurnTaskDefinition`	2.7 KiB	8.9 KiB
⚪	`agents/chat#createToolsFromClientSchemas`	114.3 KiB	545.4 KiB
⚪	`agents/chat#crossMessageToolResultUpdate`	2.4 KiB	8.6 KiB
⚪	`agents/chat#DEFAULT_CHAT_RECOVERY_MAX_ATTEMPTS`	2.3 KiB	8.2 KiB
⚪	`agents/chat#DEFAULT_CHAT_RECOVERY_MAX_OOM_RETRIES`	2.3 KiB	8.2 KiB
⚪	`agents/chat#DEFAULT_CHAT_RECOVERY_MAX_WORK`	2.3 KiB	8.2 KiB
⚪	`agents/chat#DEFAULT_CHAT_RECOVERY_NO_PROGRESS_TIMEOUT_MS`	2.3 KiB	8.2 KiB
⚪	`agents/chat#DEFAULT_CHAT_RECOVERY_STABLE_TIMEOUT_MS`	2.3 KiB	8.2 KiB
⚪	`agents/chat#DEFAULT_CHAT_RECOVERY_TERMINAL_MESSAGE`	2.4 KiB	8.3 KiB
⚪	`agents/chat#dispatchChatRecoveryToHandoff`	3.0 KiB	9.9 KiB
⚪	`agents/chat#drainInteractionApplies`	2.3 KiB	8.3 KiB
⚪	`agents/chat#enforceRowSizeLimit`	3.5 KiB	11.2 KiB
⚪	`agents/chat#hasIncompleteToolBatch`	2.4 KiB	8.6 KiB
⚪	`agents/chat#interceptAgentToolBroadcast`	2.5 KiB	8.7 KiB
⚪	`agents/chat#isPlatformFailure`	2.6 KiB	8.9 KiB
⚪	`agents/chat#isReplayChunk`	2.4 KiB	8.7 KiB
⚪	`agents/chat#iterateWithStallWatchdog`	2.6 KiB	8.8 KiB
⚪	`agents/chat#KV_DELETE_MAX_KEYS`	2.3 KiB	8.2 KiB
⚪	`agents/chat#listActiveChatRecoveryIncidents`	2.4 KiB	8.4 KiB
⚪	`agents/chat#MAX_BOUND_PARAMS`	2.3 KiB	8.2 KiB
⚪	`agents/chat#MessageType`	2.4 KiB	9.0 KiB
⚪	`agents/chat#normalizeToolInput`	2.3 KiB	8.2 KiB
⚪	`agents/chat#parseProtocolMessage`	2.5 KiB	9.0 KiB
⚪	`agents/chat#partAwaitsClientInteraction`	2.4 KiB	8.6 KiB
⚪	`agents/chat#pausedExecutionUpdate`	2.4 KiB	8.4 KiB
⚪	`agents/chat#pendingChatTerminal`	2.3 KiB	8.3 KiB
⚪	`agents/chat#persistReconstructedOrphan`	3.1 KiB	11.0 KiB
⚪	`agents/chat#PreStreamTurns`	2.6 KiB	9.3 KiB
⚪	`agents/chat#readChatRecoveryProgress`	2.3 KiB	8.3 KiB
⚪	`agents/chat#reconcileMessages`	2.8 KiB	9.6 KiB
⚪	`agents/chat#reconcileOrphanPartial`	2.4 KiB	8.5 KiB
⚪	`agents/chat#recordChatTerminal`	2.4 KiB	8.3 KiB
⚪	`agents/chat#repairInterruptedToolParts`	2.6 KiB	9.1 KiB
⚪	`agents/chat#resolveChatRecoveryConfig`	2.6 KiB	8.9 KiB
⚪	`agents/chat#resolveToolMergeId`	2.4 KiB	8.5 KiB
⚪	`agents/chat#ResumableStream`	5.1 KiB	16.8 KiB
⚪	`agents/chat#ResumeHandshake`	3.0 KiB	10.4 KiB
⚪	`agents/chat#ROW_MAX_BYTES`	2.3 KiB	8.2 KiB
⚪	`agents/chat#runChatRecoveryExhaustion`	2.6 KiB	8.9 KiB
⚪	`agents/chat#sanitizeMessage`	2.5 KiB	8.8 KiB
⚪	`agents/chat#sendIfOpen`	2.4 KiB	8.4 KiB
⚪	`agents/chat#setChatRecovering`	2.5 KiB	8.5 KiB
⚪	`agents/chat#shouldCreditStreamProgress`	2.4 KiB	8.3 KiB
⚪	`agents/chat#STREAM_RESUME_NONE_REASONS`	2.3 KiB	8.2 KiB
⚪	`agents/chat#StreamAccumulator`	2.9 KiB	10.7 KiB
⚪	`agents/chat#StreamProgressCreditThrottle`	2.4 KiB	8.3 KiB
⚪	`agents/chat#SubmitConcurrencyController`	2.9 KiB	10.3 KiB
⚪	`agents/chat#sweepStaleChatRecoveryIncidents`	2.4 KiB	8.5 KiB
⚪	`agents/chat#TextSegmentJoiner`	2.7 KiB	9.2 KiB
⚪	`agents/chat#TIMED_OUT`	2.3 KiB	8.2 KiB
⚪	`agents/chat#toolApprovalUpdate`	2.4 KiB	8.5 KiB
⚪	`agents/chat#toolPartHasSettledResult`	2.3 KiB	8.4 KiB
⚪	`agents/chat#toolResultUpdate`	2.4 KiB	8.5 KiB
⚪	`agents/chat#truncateOlderMessages`	3.2 KiB	10.4 KiB
⚪	`agents/chat#TurnQueue`	2.6 KiB	9.2 KiB
⚪	`agents/chat#unwrapChatFiberSnapshot`	2.4 KiB	8.5 KiB
⚪	`agents/chat#wrapChatFiberSnapshot`	2.3 KiB	8.2 KiB
⚪	`agents/chat-sdk#ChatSdkStateAdapter`	263.5 KiB	1152.6 KiB
⚪	`agents/chat-sdk#ChatSdkStateAgent`	262.8 KiB	1150.0 KiB
⚪	`agents/chat-sdk#createChatSdkState`	263.5 KiB	1152.6 KiB
⚪	`agents/chat-sdk#defaultKeyShard`	261.2 KiB	1141.2 KiB
⚪	`agents/chat-sdk#defaultThreadShard`	261.1 KiB	1141.0 KiB
⚪	`agents/chat/react#detectToolsRequiringConfirmation`	3.3 KiB	8.3 KiB
⚪	`agents/chat/react#extractClientToolSchemas`	3.2 KiB	8.3 KiB
⚪	`agents/chat/react#getAgentMessages`	3.4 KiB	8.6 KiB
⚪	`agents/chat/react#getToolApproval`	3.1 KiB	8.0 KiB
⚪	`agents/chat/react#getToolCallId`	3.1 KiB	8.0 KiB
⚪	`agents/chat/react#getToolInput`	3.1 KiB	8.0 KiB
⚪	`agents/chat/react#getToolOutput`	3.1 KiB	8.0 KiB
⚪	`agents/chat/react#getToolPartState`	3.2 KiB	8.2 KiB
⚪	`agents/chat/react#useAgentChat`	132.9 KiB	609.7 KiB
⚪	`agents/chat/react#WebSocketChatTransport`	5.7 KiB	17.1 KiB
⚪	`agents/chat/transport#WebSocketChatTransport`	2.8 KiB	9.2 KiB
⚪	`agents/client#AgentClient`	21.8 KiB	75.2 KiB
⚪	`agents/client#AgentConnectionError`	16.3 KiB	57.8 KiB
⚪	`agents/client#agentFetch`	19.7 KiB	69.0 KiB
⚪	`agents/client#createStubProxy`	16.4 KiB	57.8 KiB
⚪	`agents/client#DEFAULT_CALL_TIMEOUT_MS`	16.2 KiB	57.6 KiB
⚪	`agents/client#isTerminalCloseEvent`	16.3 KiB	57.6 KiB
⚪	`agents/client#nativeCall`	16.5 KiB	58.3 KiB
⚪	`agents/client#NativeCallQueue`	16.7 KiB	58.9 KiB
⚪	`agents/client#splitCallOptions`	16.3 KiB	57.7 KiB
⚪	`agents/context#AgentContextProvider`	412 B	792 B
⚪	`agents/context#AgentSearchProvider`	640 B	1.3 KiB
⚪	`agents/context#ContextBlocks`	87.4 KiB	429.7 KiB
⚪	`agents/email#createAddressBasedEmailResolver`	193 B	227 B
⚪	`agents/email#createCatchAllEmailResolver`	110 B	97 B
⚪	`agents/email#createHeaderBasedEmailResolver`	334 B	492 B
⚪	`agents/email#createSecureReplyEmailResolver`	718 B	1.3 KiB
⚪	`agents/email#DEFAULT_MAX_AGE_SECONDS`	56 B	39 B
⚪	`agents/email#isAutoReplyEmail`	201 B	249 B
⚪	`agents/email#signAgentHeaders`	424 B	812 B
⚪	`agents/experimental/webmcp#registerWebMcp`	85.2 KiB	295.8 KiB
⚪	`agents/lifecycle#getCurrentAgent`	376 B	798 B
⚪	`agents/lifecycle#Lifecycle`	8.4 KiB	26.1 KiB
⚪	`agents/lifecycle#LifecycleCapability`	497 B	999 B
⚪	`agents/mcp#createLegacyMcpHandler`	378.6 KiB	1583.3 KiB
⚪	`agents/mcp#createMcpHandler`	390.9 KiB	1628.5 KiB
⚪	`agents/mcp#DurableObjectEventStore`	345.1 KiB	1441.8 KiB
⚪	`agents/mcp#ElicitRequestSchema`	345.1 KiB	1441.8 KiB
⚪	`agents/mcp#experimental_createMcpHandler`	378.7 KiB	1583.6 KiB
⚪	`agents/mcp#getMcpAuthContext`	345.1 KiB	1441.9 KiB
⚪	`agents/mcp#MCP_SERVER_ID_MAX_LENGTH`	345.1 KiB	1441.9 KiB
⚪	`agents/mcp#McpAgent`	345.1 KiB	1441.8 KiB
⚪	`agents/mcp#normalizeServerId`	345.1 KiB	1441.8 KiB
⚪	`agents/mcp#RPC_DO_PREFIX`	345.1 KiB	1441.8 KiB
⚪	`agents/mcp#RPCClientTransport`	345.1 KiB	1441.8 KiB
⚪	`agents/mcp#RPCServerTransport`	345.1 KiB	1441.8 KiB
⚪	`agents/mcp#SSEEdgeClientTransport`	345.2 KiB	1442.1 KiB
⚪	`agents/mcp#StreamableHTTPEdgeClientTransport`	345.2 KiB	1442.1 KiB
⚪	`agents/mcp#WorkerTransport`	348.5 KiB	1458.7 KiB
⚪	`agents/mcp/client#getNamespacedData`	62.9 KiB	240.0 KiB
⚪	`agents/mcp/client#MCP_SERVER_ID_MAX_LENGTH`	62.9 KiB	239.9 KiB
⚪	`agents/mcp/client#MCPClientManager`	158.6 KiB	702.6 KiB
⚪	`agents/mcp/client#normalizeServerId`	63.0 KiB	240.2 KiB
⚪	`agents/mcp/do-oauth-client-provider#DurableObjectOAuthClientProvider`	2.1 KiB	6.6 KiB
⚪	`agents/mcp/server#createMcpHandler`	80.5 KiB	307.2 KiB
⚪	`agents/mcp/server#getMcpAuthContext`	64.0 KiB	245.5 KiB
⚪	`agents/observability#channels`	259 B	549 B
⚪	`agents/observability#genericObservability`	470 B	1.2 KiB
⚪	`agents/observability#subscribe`	324 B	668 B
⚪	`agents/observability/ai#wrapAISDK`	8.8 KiB	30.5 KiB
⚪	`agents/queue#Queue`	3.1 KiB	9.6 KiB
⚪	`agents/react#_testUtils`	19.3 KiB	66.4 KiB
⚪	`agents/react#useAgent`	27.1 KiB	89.9 KiB
⚪	`agents/react#useAgentToolEvents`	21.1 KiB	73.7 KiB
⚪	`agents/routing#getAgentByName`	795 B	1.7 KiB
⚪	`agents/routing#routeAgentRequest`	1.6 KiB	3.6 KiB
⚪	`agents/routing#RoutedAgents`	2.4 KiB	6.2 KiB
⚪	`agents/schedule#getSchedulePrompt`	85.8 KiB	424.7 KiB
⚪	`agents/schedule#scheduleSchema`	85.3 KiB	423.6 KiB
⚪	`agents/schedule#unstable_getSchedulePrompt`	85.9 KiB	424.9 KiB
⚪	`agents/schedule#unstable_scheduleSchema`	85.3 KiB	423.6 KiB
⚪	`agents/schedules#Scheduler`	6.8 KiB	22.0 KiB
⚪	`agents/schedules/parser#getSchedulePrompt`	85.8 KiB	424.7 KiB
⚪	`agents/schedules/parser#scheduleSchema`	85.3 KiB	423.6 KiB
⚪	`agents/sessions#COMPACTION_PREFIX`	147 B	160 B
⚪	`agents/sessions#createCompactFunction`	1.7 KiB	4.0 KiB
⚪	`agents/sessions#isCompactionMessage`	177 B	200 B
⚪	`agents/sessions#Session`	2.0 KiB	6.3 KiB
⚪	`agents/sessions#Sessions`	9.6 KiB	34.3 KiB
⚪	`agents/skills#fromManifest`	309.8 KiB	1084.0 KiB
⚪	`agents/skills#parseSkillFrontmatter`	328.4 KiB	1146.2 KiB
⚪	`agents/skills#parseSkillMarkdown`	328.6 KiB	1146.5 KiB
⚪	`agents/skills#r2`	330.2 KiB	1150.4 KiB
⚪	`agents/skills#runner`	369.0 KiB	1297.8 KiB
⚪	`agents/skills#SkillRegistry`	416.4 KiB	1581.7 KiB
⚪	`agents/skills/compile#compileSkillScript`	15.4 KiB	43.4 KiB
⚪	`agents/skills/compile#isCompilableSkillScript`	15.4 KiB	43.3 KiB
⚪	`agents/state#State`	1.1 KiB	2.4 KiB
⚪	`agents/streams#DEFAULT_MAX_CHUNK_BYTES`	94 B	96 B
⚪	`agents/streams#sseResponse`	857 B	1.6 KiB
⚪	`agents/streams#StreamClosedError`	175 B	212 B
⚪	`agents/streams#StreamNotFoundError`	215 B	276 B
⚪	`agents/streams#Streams`	4.3 KiB	13.9 KiB
⚪	`agents/streams#StreamSerializationError`	171 B	201 B
⚪	`agents/tasks#DuplicateTaskStepError`	328 B	463 B
⚪	`agents/tasks#MAX_SERIALIZED_BYTES`	190 B	232 B
⚪	`agents/tasks#MissingTaskDefinitionError`	358 B	536 B
⚪	`agents/tasks#NonRetryableError`	238 B	308 B
⚪	`agents/tasks#TaskReplayDivergedError`	341 B	483 B
⚪	`agents/tasks#Tasks`	8.9 KiB	31.8 KiB
⚪	`agents/tasks#TaskSerializationError`	258 B	339 B
⚪	`agents/types#MessageType`	211 B	365 B
⚪	`agents/vite#default`	353.8 KiB	1356.1 KiB
⚪	`agents/voice#addSFUTracks`	324 B	424 B
⚪	`agents/voice#createSFUSession`	255 B	306 B
⚪	`agents/voice#createSFUWebSocketAdapter`	331 B	429 B
⚪	`agents/voice#decodeVarint`	157 B	160 B
⚪	`agents/voice#downsample48kStereoTo16kMono`	238 B	324 B
⚪	`agents/voice#encodePayloadToProtobuf`	189 B	279 B
⚪	`agents/voice#encodeVarint`	129 B	122 B
⚪	`agents/voice#extractPayloadFromProtobuf`	271 B	425 B
⚪	`agents/voice#iterateText`	1.6 KiB	3.8 KiB
⚪	`agents/voice#renegotiateSFUSession`	329 B	428 B
⚪	`agents/voice#SentenceChunker`	550 B	1.1 KiB
⚪	`agents/voice#sfuFetch`	294 B	358 B
⚪	`agents/voice#upsample16kMonoTo48kStereo`	211 B	272 B
⚪	`agents/voice#VOICE_PROTOCOL_VERSION`	51 B	31 B
⚪	`agents/voice#withVoice`	9.5 KiB	32.7 KiB
⚪	`agents/voice#withVoiceInput`	4.8 KiB	16.0 KiB
⚪	`agents/voice#WorkersAIFluxSTT`	1.5 KiB	4.3 KiB
⚪	`agents/voice#WorkersAINova3STT`	1.6 KiB	4.3 KiB
⚪	`agents/voice#WorkersAITTS`	682 B	1.4 KiB
⚪	`agents/voice/client#VOICE_PROTOCOL_VERSION`	473 B	768 B
⚪	`agents/voice/client#VoiceClient`	10.1 KiB	31.6 KiB
⚪	`agents/voice/client#WebSocketVoiceTransport`	4.6 KiB	13.3 KiB
⚪	`agents/voice/errors#logVoiceError`	132 B	173 B
⚪	`agents/voice/errors#toVoiceError`	94 B	80 B
⚪	`agents/voice/errors#voiceErrorMessage`	125 B	111 B
⚪	`agents/voice/errors#VoiceProviderError`	190 B	345 B
⚪	`agents/voice/react#useVoiceAgent`	13.6 KiB	42.5 KiB
⚪	`agents/voice/react#useVoiceInput`	13.3 KiB	41.4 KiB
⚪	`agents/voice/react#WebSocketVoiceTransport`	7.4 KiB	21.3 KiB
⚪	`agents/voice/sfu#addSFUTracks`	323 B	424 B
⚪	`agents/voice/sfu#createSFUSession`	254 B	306 B
⚪	`agents/voice/sfu#createSFUWebSocketAdapter`	329 B	429 B
⚪	`agents/voice/sfu#decodeVarint`	155 B	160 B
⚪	`agents/voice/sfu#downsample48kStereoTo16kMono`	236 B	324 B
⚪	`agents/voice/sfu#encodePayloadToProtobuf`	188 B	279 B
⚪	`agents/voice/sfu#encodeVarint`	129 B	122 B
⚪	`agents/voice/sfu#extractPayloadFromProtobuf`	270 B	425 B
⚪	`agents/voice/sfu#renegotiateSFUSession`	329 B	428 B
⚪	`agents/voice/sfu#sfuFetch`	292 B	358 B
⚪	`agents/voice/sfu#upsample16kMonoTo48kStereo`	209 B	272 B
⚪	`agents/voice/text#iterateText`	1.6 KiB	3.8 KiB
⚪	`agents/voice/text#SentenceChunker`	549 B	1.1 KiB
⚪	`agents/voice/types#VOICE_PROTOCOL_VERSION`	51 B	31 B
⚪	`agents/voice/workers-ai#WorkersAIFluxSTT`	1.5 KiB	4.3 KiB
⚪	`agents/voice/workers-ai#WorkersAINova3STT`	1.6 KiB	4.3 KiB
⚪	`agents/voice/workers-ai#WorkersAITTS`	682 B	1.4 KiB
⚪	`agents/websockets#CAPNWEB_TRANSPORT_QUERY`	12.4 KiB	43.3 KiB
⚪	`agents/websockets#CAPNWEB_TRANSPORT_VALUE`	12.4 KiB	43.3 KiB
⚪	`agents/websockets#capnWebTransportUrl`	12.5 KiB	43.5 KiB
⚪	`agents/websockets#CF_NO_PROTOCOL_KEY`	12.4 KiB	43.3 KiB
⚪	`agents/websockets#CF_READONLY_KEY`	12.4 KiB	43.3 KiB
⚪	`agents/websockets#isCapnWebTransportUpgrade`	12.5 KiB	43.4 KiB
⚪	`agents/websockets#registerInternalConnectionKeys`	12.4 KiB	43.4 KiB
⚪	`agents/websockets#WebSockets`	20.0 KiB	69.3 KiB
⚪	`agents/workflows#AgentWorkflow`	262.4 KiB	1145.7 KiB
⚪	`agents/workflows#WorkflowRejectedError`	261.2 KiB	1141.2 KiB
⚪	`agents/x402#normalizeNetwork`	14.7 KiB	61.1 KiB
⚪	`agents/x402#withX402`	23.0 KiB	89.2 KiB
⚪	`agents/x402#withX402Client`	104.1 KiB	346.5 KiB

Reported by agent-think[bot].

devin-ai-integration

Devin Review found 3 potential issues.

devin-ai-integration · 2026-09-23T14:42:37Z

+    this._broadcastChatMessage(
+      errorText !== undefined &&
+        message.type === MessageType.CF_AGENT_USE_CHAT_RESPONSE &&
+        !message.error
+        ? { ...message, body: errorText, error: true }
+        : message,
+      exclude


📝 Info: Existing stream errors survive release

Persistence failure rewrites only successful held frames. An existing terminal error keeps its original diagnostic body.

Was this helpful? React with 👍 or 👎 to provide feedback.

Yes, intended: an existing stream error is more specific than the persistence failure, so it is kept.

devin-ai-integration · 2026-09-23T14:42:39Z

+        this._heldTerminalFrames.set(id, null);
+        let persisted = false;


📝 Info: Empty responses need no hold

The no-body branch registers no held frame. It creates no assistant transcript broadcast that can follow and overwrite newer client state.

Was this helpful? React with 👍 or 👎 to provide feedback.

Agreed, no change needed.

pkg-pr-new · 2026-09-23T14:44:18Z

Open in StackBlitz

agents

npm i https://pkg.pr.new/agents@2334

@cloudflare/ai-chat

npm i https://pkg.pr.new/@cloudflare/ai-chat@2334

@cloudflare/codemode

npm i https://pkg.pr.new/@cloudflare/codemode@2334

hono-agents

npm i https://pkg.pr.new/hono-agents@2334

@cloudflare/shell

npm i https://pkg.pr.new/@cloudflare/shell@2334

@cloudflare/think

npm i https://pkg.pr.new/@cloudflare/think@2334

@cloudflare/voice

npm i https://pkg.pr.new/@cloudflare/voice@2334

@cloudflare/worker-bundler

npm i https://pkg.pr.new/@cloudflare/worker-bundler@2334

commit: 39dff48

useAgentChat switches to ready on done, but AIChatAgent sent it before persisting the reply and broadcasting cf_agent_chat_messages, so on programmatic turns and in other tabs a message sent right after the reply could be replaced by the late snapshot. While _reply owns a request its terminal frame is held in _broadcastChatMessage and released after the persist; a failed persist releases it as an error frame. Same ordering fix as #2327 for Think. Co-authored-by: Cursor <cursoragent@cursor.com>

… persisted An SSE error chunk is broadcast as error: true, done: false before the done frame, and clients end the stream on either. Hold every terminal frame for the request, in order, and release them after the persist. Co-authored-by: Cursor <cursoragent@cursor.com>

## pnpm-workspace.yaml (default) ## Dependency Updates | Package | From | To | Type | | --- | --- | --- | --- | | `@cloudflare/ai-chat` | 0.12.0 | 0.12.1 | patch | ## Release Notes <details> <summary><b>@cloudflare/ai-chat</b> (0.12.0 → 0.12.1)</summary> ### Patch Changes - [#2390](cloudflare/agents#2390) [`c55ec80`](cloudflare/agents@c55ec80) Thanks [@threepointone](https://github.com/threepointone)! - Report a failed agent-tool child as failed even when it was evicted before recording the failure. See [Agent tools](https://github.com/cloudflare/agents/blob/main/docs/agents/agent-tools.md). - [#2384](cloudflare/agents#2384) [`f904999`](cloudflare/agents@f904999) Thanks [@threepointone](https://github.com/threepointone)! - Fix agent-tool chunks being duplicated or dropped on reconnect, child re-attach, and fiber recovery. See [Agent tools](https://github.com/cloudflare/agents/blob/main/docs/agents/agent-tools.md). - [#2364](cloudflare/agents#2364) [`5e0507e`](cloudflare/agents@5e0507e) Thanks [@threepointone](https://github.com/threepointone)! - Add `eventDelivery: "terminal"` to `runAgentTool` to forward only lifecycle, progress, and milestone events for a run. See [Agent tools](https://github.com/cloudflare/agents/blob/main/docs/agents/agent-tools.md). - [#2334](cloudflare/agents#2334) [`7f564e7`](cloudflare/agents@7f564e7) Thanks [@threepointone](https://github.com/threepointone)! - AI Chat and Think send the terminal `done` frame after persisting and broadcasting the assistant reply, so later sends are not overwritten. See [Chat agents](https://github.com/cloudflare/agents/blob/main/docs/agents/chat-agents.md). - [#2352](cloudflare/agents#2352) [`449ac27`](cloudflare/agents@449ac27) Thanks [@threepointone](https://github.com/threepointone)! - Do not start an automatic continuation after an …[full notes](https://github.com/cloudflare/agents/releases/tag/%40cloudflare/ai-chat%400.12.1) </details> --- *This PR was auto-generated by [catalog-update-action](https://github.com/brandhaug/catalog-update-action).* Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

…ge ids and per-event seq Ports the server half of upstream cloudflare#2334, cloudflare#2365, cloudflare#2378, cloudflare#2383 and cloudflare#2348 into AGUIChatAgent. An in-band RUN_ERROR now marks its stream errored when the body ends (a settled stream cannot be re-marked, which had broken cloudflare#1575's errored replay) and rides an error frame the client transport still delivers as an event.

devin-ai-integration Bot reviewed Sep 23, 2026

View reviewed changes

threepointone force-pushed the fix/ai-chat-persist-before-done branch from 20f220d to a56a8d7 Compare September 23, 2026 14:53

threepointone merged commit 7f564e7 into main Sep 23, 2026
11 of 12 checks passed

threepointone deleted the fix/ai-chat-persist-before-done branch September 23, 2026 18:41

github-actions Bot mentioned this pull request Sep 23, 2026

Version Packages #2335

Merged

threepointone mentioned this pull request Sep 27, 2026

fix(chat): settle turns correctly across replay, resume, and observers #2383

Merged

brandhaug mentioned this pull request Oct 5, 2026

chore(deps): bump @cloudflare/ai-chat from 0.12.0 to 0.12.1 brandhaug/b2b-saas-starter#579

Merged

Navigation Menu

Repository navigation

fix(ai-chat): send the done frame after the transcript is persisted - #2334

fix(ai-chat): send the done frame after the transcript is persisted#2334
threepointone merged 2 commits into
mainfrom
fix/ai-chat-persist-before-done

threepointone commented Sep 23, 2026 •

edited by devin-ai-integration Bot

Loading

Uh oh!

changeset-bot Bot commented Sep 23, 2026 •

edited

Loading

Uh oh!

agent-think Bot commented Sep 23, 2026 •

edited

Loading

Uh oh!

devin-ai-integration Bot left a comment

Uh oh!

Uh oh!

devin-ai-integration Bot Sep 23, 2026 •

edited

Loading

Uh oh!

threepointone Sep 23, 2026

Uh oh!

devin-ai-integration Bot Sep 23, 2026 •

edited

Loading

Uh oh!

threepointone Sep 23, 2026

Uh oh!

pkg-pr-new Bot commented Sep 23, 2026 •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

		this._heldTerminalFrames.set(id, null);
		let persisted = false;

Conversation

threepointone commented Sep 23, 2026 • edited by devin-ai-integration Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Problem

Fix

Uh oh!

changeset-bot Bot commented Sep 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🦋 Changeset detected

Uh oh!

agent-think Bot commented Sep 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

⚪ agents import sizes

Uh oh!

devin-ai-integration Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

devin-ai-integration Bot Sep 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

threepointone Sep 23, 2026

Choose a reason for hiding this comment

Uh oh!

devin-ai-integration Bot Sep 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

threepointone Sep 23, 2026

Choose a reason for hiding this comment

Uh oh!

pkg-pr-new Bot commented Sep 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

threepointone commented Sep 23, 2026 •

edited by devin-ai-integration Bot

Loading

changeset-bot Bot commented Sep 23, 2026 •

edited

Loading

agent-think Bot commented Sep 23, 2026 •

edited

Loading

devin-ai-integration Bot Sep 23, 2026 •

edited

Loading

devin-ai-integration Bot Sep 23, 2026 •

edited

Loading

pkg-pr-new Bot commented Sep 23, 2026 •

edited

Loading