Repository navigation
fix(think): load messenger attachments delivered as ArrayBuffer (#2311) - #2323
Merged
threepointone merged 1 commit intoSep 23, 2026
Conversation
🦋 Changeset detectedLatest commit: 6a4b2b7 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
threepointone
added this pull request to stack #2332
September 23, 2026 14:18
Contributor
⚪ agents import sizesMeasured 343 runtime imports as minified bundles. The primary size is gzip; raw minified size is included for diagnosis. An existing import growing by more than 10% is marked red. This report is informational.
Compared No import sizes changed. All 343 current runtime imports
Reported by agent-think[bot]. |
agents
@cloudflare/ai-chat
@cloudflare/codemode
hono-agents
@cloudflare/shell
@cloudflare/think
@cloudflare/voice
@cloudflare/worker-bundler
commit: |
Co-authored-by: Hariom Sharma <hariom.s2510@gmail.com> Co-authored-by: Cursor <cursoragent@cursor.com>
threepointone
force-pushed
the
fix/2311-messenger-arraybuffer-attachments
branch
from
September 23, 2026 14:52
cd67447 to
6a4b2b7
Compare
threepointone
deleted the
fix/2311-messenger-arraybuffer-attachments
branch
September 23, 2026 18:41
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
toMessengerAttachmentassumedfetchData()always resolves to aBuffer, and readdata.buffer. Fromchat@4.41, which is inside Think's^4.31.0range, adapters can resolve a plainArrayBuffer. AnArrayBufferhas no.buffer, so the conversion threw and messenger attachments failed to load.Fix
A small
attachmentBytes()helper returns anArrayBufferas is. For aBufferor other view, it copies out only the view's own byte range, because aBuffercan share a pooled orSharedArrayBufferbacking store with unrelated bytes.Validation: New regressions cover an
ArrayBufferresult, a pooledBufferslice (only its own bytes are returned), and a missing result. The messenger suite andpnpm run checkpassed.Fixes #2311
Thanks to @harryy2510 for the report and the fix direction (co-authored).
Stacked PR 2 of 10. Base: #2322.