Repository navigation
fix(ai-chat): avoid stale MCP tool calls pinning isStreaming - #1654
Merged
Merged
Conversation
🦋 Changeset detectedLatest commit: d85f5dc The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
agents
@cloudflare/ai-chat
@cloudflare/codemode
hono-agents
@cloudflare/shell
@cloudflare/think
@cloudflare/voice
@cloudflare/worker-bundler
commit: |
cjol
force-pushed
the
bug/isstreaming-abort-toolcall
branch
from
June 2, 2026 13:44
eef839d to
3674caa
Compare
threepointone
force-pushed
the
bug/isstreaming-abort-toolcall
branch
from
June 3, 2026 11:57
54cb6d7 to
d85f5dc
Compare
threepointone
approved these changes
Jun 3, 2026
threepointone
left a comment
Contributor
There was a problem hiding this comment.
clean, lgtm, thanks! will land after CI passes (I rebased)
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes #1614, where
useAgentChat().isStreamingcould remain true after aborting while a server-side MCP tool call was in flight.Investigation summary:
examples/ai-chatapp connected to an MCP server with a delayed tool.statustoready, but the UI still derivedisStreaming: truefrom a persistedinput-availabletool part.onToolCallfor browser/client tools, while the delayed MCP tool is server-owned.input-availabletool part as pending client work wheneveronToolCallexisted, even when that tool was an MCP/server-side tool the client did not handle.onToolCallcallbacks rather than using the presence ofonToolCallas a proxy.Problem:
input-availableif the user aborts before the tool output arrives.onToolCallfor unrelated browser tools.isStreamingtrue indefinitely, including after reconnect/hydration.Solution:
onToolCallcallback is actually in flight.!!onToolCall.isStreamingtrue while they are actively running.onToolCalldoes not handle.@cloudflare/ai-chat.