Skip to content

Convert ServiceChain plugin to NestJS module#2019

Open
StephaneTrebel wants to merge 3 commits intomainfrom
convert-opencds-nestjs
Open

Convert ServiceChain plugin to NestJS module#2019
StephaneTrebel wants to merge 3 commits intomainfrom
convert-opencds-nestjs

Conversation

@StephaneTrebel
Copy link
Copy Markdown
Collaborator

@StephaneTrebel StephaneTrebel commented Mar 20, 2026

Issues liées

Issues numéro: #1983

@StephaneTrebel StephaneTrebel added this to the MCO milestone Mar 20, 2026
@StephaneTrebel StephaneTrebel self-assigned this Mar 20, 2026
@github-actions github-actions bot added the built label Mar 20, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Mar 20, 2026 •
edited
Loading

🤖 Hey !

The security scan report for the current pull request is available here.

@StephaneTrebel StephaneTrebel force-pushed the convert-opencds-nestjs branch from d1bbe44 to 23cc295 Compare March 23, 2026 09:51
@StephaneTrebel StephaneTrebel force-pushed the convert-opencds-nestjs branch from 23cc295 to 3f689e8 Compare March 23, 2026 09:52
@StephaneTrebel StephaneTrebel disabled auto-merge March 23, 2026 09:52
@StephaneTrebel StephaneTrebel force-pushed the convert-opencds-nestjs branch 2 times, most recently from fb683c2 to 4e7ad49 Compare March 26, 2026 14:33
@StephaneTrebel StephaneTrebel changed the title Convert opencds plugin to NestJS module Convert ServiceChain plugin to NestJS module Mar 26, 2026
@StephaneTrebel StephaneTrebel mentioned this pull request Mar 26, 2026
Open
@StephaneTrebel StephaneTrebel force-pushed the convert-opencds-nestjs branch 3 times, most recently from 1f719cd to 8f6bfdc Compare March 26, 2026 15:27
@StephaneTrebel StephaneTrebel added the preview Deploy preview app with Argo-cd label Mar 26, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Mar 26, 2026

🤖 Hey !

A preview of the application is available at : https://console-pr-2019.dso.cpin-hp.numerique-interieur.fr

Please be patient, deployment may take a few minutes.

@StephaneTrebel StephaneTrebel force-pushed the convert-opencds-nestjs branch from 8f6bfdc to 8d74ca8 Compare March 30, 2026 07:27
shikanime
shikanime requested changes Mar 31, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@shikanime shikanime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On utilise NestJS, autant reellement utiliser le framework a fond via @nestjs/testing avec un typage fort jusqu'au mocks. J'ai eux pas mal d'occasion ou les mocks n'etait plus en sync avec les implementations reel qui ont fausse les tests

@shikanime shikanime mentioned this pull request Apr 1, 2026
Closed
@StephaneTrebel StephaneTrebel force-pushed the convert-opencds-nestjs branch 7 times, most recently from 2b210cc to 89f1dba Compare April 9, 2026 14:11
@StephaneTrebel StephaneTrebel requested a review from shikanime April 9, 2026 14:17
@StephaneTrebel StephaneTrebel force-pushed the convert-opencds-nestjs branch from 89f1dba to 9d3eb71 Compare April 13, 2026 13:36
@StephaneTrebel StephaneTrebel added preview Deploy preview app with Argo-cd and removed preview Deploy preview app with Argo-cd labels Apr 13, 2026
@StephaneTrebel StephaneTrebel force-pushed the convert-opencds-nestjs branch from 9d3eb71 to bd3691a Compare April 13, 2026 14:04
@StephaneTrebel StephaneTrebel added preview Deploy preview app with Argo-cd and removed preview Deploy preview app with Argo-cd labels Apr 13, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 13, 2026

🤖 Hey !

The security scan report for the current pull request is available here.

@StephaneTrebel StephaneTrebel force-pushed the convert-opencds-nestjs branch from bd3691a to f745221 Compare April 13, 2026 14:11
@StephaneTrebel StephaneTrebel added preview Deploy preview app with Argo-cd and removed preview Deploy preview app with Argo-cd labels Apr 13, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 13, 2026

🤖 Hey !

A preview of the application is available at : https://console-pr-2019.dso.cpin-hp.numerique-interieur.fr

Please be patient, deployment may take a few minutes.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 13, 2026

🤖 Hey !

The security scan report for the current pull request is available here.

@cloud-pi-native-sonarqube
Copy link
Copy Markdown

cloud-pi-native-sonarqube bot commented Apr 13, 2026

Failed Quality Gate failed

  • 50.00% Security Hotspots Reviewed on New Code (is less than 100.00%)

Project ID: cloud-pi-native_console_AYsa46O31ebDtzs-pYyZ

View in SonarQube

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 13, 2026

🤖 Hey !

The security scan report for the current pull request is available here.

shikanime
shikanime approved these changes Apr 14, 2026
View reviewed changes
apps/server-nestjs/src/cpin-module/service-chain/open-cds-client.service.ts
const openCdsDisabledMessage = 'OpenCDS is disabled, please set OPENCDS_URL in your relevant .env file. See .env-example'

@Injectable()
export class OpenCdsClientService {
Copy link
Copy Markdown
Member

@shikanime shikanime Apr 14, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Idealement comme on fait table rase, on devrait drop Axios comme dependence vers juste fetch natif.

apps/server-nestjs/src/cpin-module/service-chain/service-chain.service.spec.ts

const uuid = '550e8400-e29b-41d4-a716-446655440000'

const mockServiceChain = {
Copy link
Copy Markdown
Member

@shikanime shikanime Apr 14, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ajout du typage pour la detection de refacto, peut-etre une fonction makexxx comme dans les autres tests, car c'est une base spread dans les tests.

Copy link
Copy Markdown
Collaborator Author

@StephaneTrebel StephaneTrebel Apr 14, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oui une factory serait vachement mieux, bien vu !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@shikanime shikanime shikanime approved these changes

@iliesmrf iliesmrf Awaiting requested review from iliesmrf

+1 more reviewer

@github-code-quality github-code-quality[bot] github-code-quality[bot] left review comments

Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

@StephaneTrebel StephaneTrebel

Labels

built preview Deploy preview app with Argo-cd

Projects

None yet

Milestone

MCO

Development

Successfully merging this pull request may close these issues.

3 participants

@StephaneTrebel @shikanime @iliesmrf