UX: Move approval toggles off topbar; outline destructive Disconnect#231
UX: Move approval toggles off topbar; outline destructive Disconnect#231parkerbyrd-ux wants to merge 2 commits into
Conversation
- Remove Auto-Approve All, Pause Incoming Commands, and Disconnect from the topbar header so approval/connection UI is no longer surfaced in the top navigation - Inline the two toggles with Refresh/Clear on the Approvals page, right-aligned via margin-left: auto so they sit opposite the actions - Move Disconnect to the bottom of the Connection Status section in Settings -> Relay / Gateway - Add a .actions button.destructive-outline style (transparent bg, destructive border + text, soft hover) and apply it to Disconnect; toggle to .secondary when the label flips to "Reconnect" so the destructive treatment only shows for the destructive action - Bump desktop to 0.15.74 Testing: just desktop-typecheck and just desktop-lint both pass Risks: None identified -- DOM ids (dangerAutoApproveToggle, headerPauseToggle, dangerAutoApproveLabel, headerConnectionToggle) are preserved so all existing JS wiring continues to work. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits. |
thadeusb
left a comment
thadeusb
left a comment
There was a problem hiding this comment.
Straightforward UI shuffle. IDs stayed the same so all the JS bindings still work, class toggle logic is correct.
…proval-toggles # Conflicts: # apps/desktop/package.json
mikeangstadt
left a comment
mikeangstadt
left a comment
There was a problem hiding this comment.
Review
Clean UI shuffle — the Auto-Approve All and Pause toggles belong in the Approvals panel next to the queue actions, and the Disconnect button fits naturally in Settings > Connection Status.
IDs preserved, JS bindings intact — all element references use document.getElementById(), so relocating them in the DOM is safe. The headerConnectionToggle class toggle (destructive-outline when connected, secondary when reconnecting) is wired correctly.
One cleanup opportunity: The CSS rule .topbar .topbar-actions at index.html:2967 is now orphaned since the <div class="topbar-actions"> was removed from the header. Consider dropping it to keep stylesheet clean.
Otherwise looks good.
Auto-reviewed by opencode headless
3 participants
Summary
Test plan
just desktop-typecheckjust desktop-lintFeature flags
[flag:N/A] Not applicable -- this is a UI relocation/restyle within the desktop app, with no critical-path or rollout risk.
Generated with Claude Code