Skip to content

Document attachment support in gh skill - #14261

Merged
BagToad merged 1 commit into
bagtoad/attach-flag-wrapperfrom
bagtoad/update-gh-skill
Aug 25, 2026
Merged

Document attachment support in gh skill#14261
BagToad merged 1 commit into
bagtoad/attach-flag-wrapperfrom
bagtoad/update-gh-skill

Conversation

@BagToad

@BagToad BagToad commented Aug 25, 2026

Copy link
Copy Markdown
Member

Related implementation: #14255

Description

The installable gh agent skill does not describe the new repeatable --attach flag. Agents using the skill would miss the supported commands, argument format, Markdown rewriting, video behavior, incompatible modes, authentication requirements, and partial-failure contract.

This adds one concise attachment section to skills/gh/SKILL.md, following the skill's existing bullet-oriented style and inline command examples.

How did you test this change?

I previewed the installable skill package with gh skill publish --dry-run . and read the rendered source alongside the command help and attachment tests on the parent branch.

Key points

  • Covers all six issue, pull request, and comment commands that support attachments.
  • Keeps invocation guidance in the gh skill rather than documenting implementation details.
  • Distinguishes image alt text, standalone video players, inline video links, and unsupported reference-style video images.
  • Records the host, token, permission, conflict, and partial-failure constraints agents need before invoking the flag.

Notes for reviewers

Review the new Attaching images and videos section in skills/gh/SKILL.md. The file path is the tracked skill source installed by gh skill install cli/cli gh --scope user.

Authorship and follow-up

Who wrote this:

  • A human wrote it.
  • An agent wrote it under close human direction.
  • An agent wrote it independently, and no human has guided the implementation beyond the initial prompt.

Who answers review comments:

  • @BagToad will read and reply directly. Name the account.
  • An agent will draft replies and @username will read them before they are posted.
  • Nobody has explicitly committed to replying.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
@BagToad
BagToad requested a review from a team as a code owner August 25, 2026 16:06
@BagToad
BagToad requested review from babakks and removed request for a team August 25, 2026 16:06
@BagToad BagToad changed the title bagtoad/update gh skill Document attachment support in gh skill Aug 25, 2026
@BagToad BagToad changed the title Document attachment support in gh skill Document attachment support in gh skill Aug 25, 2026

@babakks babakks left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for capping off the stack with the docs, @BagToad! 📚

The attachment section reads clearly and covers the important edges: supported file types, alt text syntax and shell quoting, the reference-rewrite versus append behavior, the video limitations, the per-command conflicts, and the partial-upload exit semantics. Nice and thorough.

I left one small suggestion: it would help to spell out that the filesystem paths in the body markdown and in --attach resolve either as absolute paths or relative to the directory where gh runs. Non-blocking.

Nice work landing the whole stack! 🎉

Comment thread skills/gh/SKILL.md
@BagToad
BagToad merged commit cc83172 into trunk Aug 25, 2026
41 checks passed
@BagToad
BagToad deleted the bagtoad/update-gh-skill branch August 25, 2026 21:30
@BagToad BagToad mentioned this pull request Aug 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants