Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 28 additions & 0 deletions packages/clerk-js/src/core/cacheClearManager.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,28 @@
import { debugLogger } from '@/utils/debug';

const clearCallbacks = new Map<string, () => void>();

/**
* Registers a callback to be executed when caches are cleared.
* @param id - Unique identifier for the callback
* @param callback - Function to execute when clearing caches
* @returns Function to unregister the callback
*/
export const registerClearCallback = (id: string, callback: () => void): (() => void) => {
clearCallbacks.set(id, callback);
return () => clearCallbacks.delete(id);
};

/**
* Clears all registered caches by executing all registered callbacks.
* Continues execution even if individual callbacks throw errors.
*/
export const clearAllCaches = (): void => {
clearCallbacks.forEach(callback => {
try {
callback();
} catch (error) {
debugLogger.error('Error executing clear callback', { error }, 'CacheClearManager');
}
});
};
9 changes: 9 additions & 0 deletions packages/clerk-js/src/core/clerk.ts
Original file line number Diff line number Diff line change
Expand Up @@ -525,6 +525,15 @@ export class Clerk implements ClerkInterface {
// Notify other tabs that user is signing out and clean up cookies.
eventBus.emit(events.UserSignOut, null);

if (typeof window !== 'undefined') {
try {
const { clearAllCaches } = await import('./cacheClearManager');
clearAllCaches();
} catch (error) {
debugLogger.debug('CacheClearManager not available during signOut, skipping cache clear', { error }, 'clerk');
}
}

this.#setTransitiveState();

await tracker.track(async () => {
Expand Down
61 changes: 61 additions & 0 deletions packages/clerk-js/src/core/requestCache.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,61 @@
import { debugLogger } from '@/utils/debug';

export type RequestCacheState<T = unknown> = {
data: T | null;
error: Error | null;
isLoading: boolean;
isValidating: boolean;
cachedAt?: number;
};

const cache = new Map<string, RequestCacheState<unknown>>();
const subscribers = new Set<() => void>();

/**
* Gets a cache entry
*/
export const getCacheEntry = <T>(key: string): RequestCacheState<T> | undefined => {
return cache.get(key) as RequestCacheState<T> | undefined;
};

/**
* Sets a cache entry and notifies subscribers
*/
export const setCacheEntry = <T>(
key: string,
state: RequestCacheState<T> | ((current: RequestCacheState<T> | undefined) => RequestCacheState<T>),
): void => {
const currentState = cache.get(key) as RequestCacheState<T> | undefined;
const newState = typeof state === 'function' ? state(currentState) : state;
cache.set(key, newState as RequestCacheState<unknown>);
notifySubscribers();
};

/**
* Subscribes to cache changes
*/
export const subscribe = (callback: () => void): (() => void) => {
subscribers.add(callback);
return () => subscribers.delete(callback);
};

/**
* Clears the entire request cache
*/
export const clearRequestCache = (): void => {
cache.clear();
notifySubscribers();
};

/**
* Notifies all subscribers of cache changes
*/
const notifySubscribers = (): void => {
subscribers.forEach(callback => {
try {
callback();
} catch (error) {
debugLogger.error('Error executing subscriber callback', { error }, 'RequestCache');
}
});
};
66 changes: 29 additions & 37 deletions packages/clerk-js/src/ui/hooks/useFetch.ts
Original file line number Diff line number Diff line change
@@ -1,54 +1,43 @@
import { useCallback, useEffect, useRef, useSyncExternalStore } from 'react';

export type State<Data = any, Error = any> = {
data: Data | null;
error: Error | null;
/**
* if there's an ongoing request and no "loaded data"
*/
isLoading: boolean;
/**
* if there's a request or revalidation loading
*/
isValidating: boolean;
cachedAt?: number;
};

/**
* Global cache for storing status of fetched resources
*/
let requestCache = new Map<string, State>();

/**
* A set to store subscribers in order to notify when the value of a key of `requestCache` changes
*/
const subscribers = new Set<() => void>();
import { registerClearCallback } from '@/core/cacheClearManager';
import {
clearRequestCache,
getCacheEntry,
type RequestCacheState,
setCacheEntry,
subscribe,
} from '@/core/requestCache';

/**
* This utility should only be used in tests to clear previously fetched data
*/
export const clearFetchCache = () => {
requestCache = new Map<string, State>();
clearRequestCache();
};

if (typeof window !== 'undefined') {
registerClearCallback('useFetch', clearFetchCache);
}

const serialize = (key: unknown) => (typeof key === 'string' ? key : JSON.stringify(key));

const useCache = <K = any, V = any>(
key: K,
serializer = serialize,
): {
getCache: () => State<V> | undefined;
setCache: (state: State<V> | ((params: State<V>) => State<V>)) => void;
getCache: () => RequestCacheState<V> | undefined;
setCache: (
state: RequestCacheState<V> | ((params: RequestCacheState<V> | undefined) => RequestCacheState<V>),
) => void;
clearCache: () => void;
subscribeCache: (callback: () => void) => () => void;
} => {
const serializedKey = serializer(key);
const get = useCallback(() => requestCache.get(serializedKey), [serializedKey]);
const get = useCallback(() => getCacheEntry<V>(serializedKey), [serializedKey]);
const set = useCallback(
(data: State | ((params: State) => State)) => {
// @ts-ignore
requestCache.set(serializedKey, typeof data === 'function' ? data(get()) : data);
subscribers.forEach(callback => callback());
(data: RequestCacheState<V> | ((params: RequestCacheState<V> | undefined) => RequestCacheState<V>)) => {
setCacheEntry(serializedKey, data);
},
[serializedKey],
);
Expand All @@ -62,15 +51,14 @@ const useCache = <K = any, V = any>(
cachedAt: undefined,
});
}, [set]);
const subscribe = useCallback((callback: () => void) => {
subscribers.add(callback);
return () => subscribers.delete(callback);
const subscribeCache = useCallback((callback: () => void) => {
return subscribe(callback);
}, []);

return {
getCache: get,
setCache: set,
subscribeCache: subscribe,
subscribeCache,
clearCache: clear,
};
};
Expand Down Expand Up @@ -116,11 +104,15 @@ export const useFetch = <K, T>(
const revalidateCache = useSyncExternalStore(subscribeRevalidationCounter, getRevalidationCounter);

const revalidate = useCallback(() => {
setCache(d => ({
setCache((d: RequestCacheState<T> | undefined) => ({
data: null,
error: null,
isLoading: false,
isValidating: false,
...d,
cachedAt: 0,
}));
setRevalidationCounter(d => ({
setRevalidationCounter((d: RequestCacheState<number> | undefined) => ({
isLoading: false,
isValidating: false,
error: null,
Expand Down
Loading