fix(shared): Invitations depends on wrong options (useOrganization)#2472
Merged
panteliselef merged 4 commits intomainfrom Jan 4, 2024
Merged
fix(shared): Invitations depends on wrong options (useOrganization)#2472panteliselef merged 4 commits intomainfrom
panteliselef merged 4 commits intomainfrom
Conversation
🦋 Changeset detectedLatest commit: 470ab5a The changes in this PR will be included in the next version bump. This PR includes changesets to release 12 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
brkalow
approved these changes
Jan 3, 2024
.changeset/thirty-cooks-cheer.md
Outdated
| '@clerk/shared': patch | ||
| --- | ||
|
|
||
| Bug fix: Invitations from useOrganization depends on options of membership.} |
Member
There was a problem hiding this comment.
Suggested change
| Bug fix: Invitations from useOrganization depends on options of membership.} | |
| Fixes a bug where Invitations from `useOrganization` incorrectly depended on options for memberships. |
dimkl
approved these changes
Jan 4, 2024
dimkl
reviewed
Jan 4, 2024
Contributor
dimkl
left a comment
dimkl
left a comment
There was a problem hiding this comment.
I think that this bug indicates that we have no test coverage over this part of the codebase. Could we introduce a unit test for this?
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jan 4, 2024
…2472) (#2481) * fix(shared): Invitations depends on wrong options (useOrganization) (#2472) * fix(shared): Invitations depends on wrong options (useOrganization) * fix(shared): Invitations is depending on wrong options * test(clerk-js): Add unit test * chore(clerk-js): Update changeset (cherry picked from commit 38d8b3e) * fix(clerk-js): Use useCoreOrganization --------- Co-authored-by: panteliselef <panteliselef@outlook.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes a bug which would make the
useOrganizationwith theinvitationsparam to work unexpectedly.Checklist
npm testruns as expected.npm run buildruns as expected.Type of change
Packages affected
@clerk/backend@clerk/chrome-extension@clerk/clerk-js@clerk/clerk-expo@clerk/fastifygatsby-plugin-clerk@clerk/localizations@clerk/nextjs@clerk/clerk-react@clerk/remix@clerk/clerk-sdk-node@clerk/shared@clerk/themes@clerk/typesbuild/tooling/chore