Repository navigation
Conversation
🦋 Changeset detectedLatest commit: 07447db The changes in this PR will be included in the next version bump. This PR includes changesets to release 10 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Publish newly tracked properties after commit while retaining one signal effect per target. Preserve observer baselines across proxy reads and handle target replacement, synchronous updates, and Strict Mode cleanup. Add browser regression coverage for late reads, object-valued getters, subscription stability, batching, and lifecycle behavior.
@dnd-kit/abstract
@dnd-kit/collision
@dnd-kit/dom
@dnd-kit/geometry
@dnd-kit/helpers
@dnd-kit/react
@dnd-kit/solid
@dnd-kit/state
@dnd-kit/svelte
@dnd-kit/vue
commit: |
clauderic
approved these changes
Sep 12, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
A component can start reading draggable, droppable, or sortable state after its initial render—for example, after enabling a setting that displays
isDragSource. React, Vue, Solid, and Svelte recorded the newly accessed property but could miss subsequent updates because the signal effect had not subscribed to it.Getters that return a new object on every read, such as independently configured
sortable.disabledflags, also expose update loops when subscriptions or notification counters feed back into rendering.Change
To try the original scenario, open
react-sortable--conditional-state, enable Show drag state, and drag Item 1. Its status should change fromIdletoDraggingand back.Validation
Tested locally with Node 22.16.0, Bun 1.3.11, and the locked dependencies.
git diff --checkpassed.effect_update_depth_exceededfor a fresh-object getter. The original React PR implementation reproduces its render loop in both normal and Strict Mode tests.ESLint cannot start with the locked dependency tree:
TypeError: Cannot set properties of undefined (setting 'defaultMeta')in@eslint/eslintrc/Ajv, before inspecting source files.AI assistance: Prepared and updated with OpenAI Codex; the listed builds and tests were run locally.