Bootstrap 3 to 5 migration - #433
Conversation
and replace .style:base-style dependency as the source of the CLARIN look. Includes the Bootstrap 3 compatibility shim (_bootstrap3-compat.scss), which re-implements the Bootstrap 3 class names the markup still uses on top of Bootstrap 5 primitives.
⛔ Snyk checks have failed. 13 issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
There was a problem hiding this comment.
In general, it looks good. I can compile it out of the box on my machine without any issues.
See below for some small things I found:
Mobile hamburger menu
There is a change in the highlighting of the hovered item in the top menu on mobile. I think the current version looks better.
Record page: placement of the options menu trigger on the handle page 'big link'
This has shifted to the centre, which is unexpected.
Record page: search buttons too big
There appears to be much more padding, which leads to an wonky layout inside the table.
Record page: darkness of rows with gray background
The darker background of the rows with record (technical) details is darker than the current production version, which looks slightly worse in my opinion. Also the contrast might be a bit lower because of this. I would prefer the same shade of gray as on current production.
Search results: lack of spacing below second paginator
"Add to VCR" functionality
- The "+VCR" link in the search results and record page doesn't behave like a normal link (compare production to PR version, i.e. the pointer and the underline)
- An off-looking error box appears in the queue 'popup' after adding an item (running locally)
Pointing right icon
In the modal that is activated by clicking a handle or DOI link in the record page.
I think the font awesome's pointing hand icon looks a bit odd, perhaps hard to decipher. Perhaps replace this with the solid version or replace with angles-right:
OR








This upgrades our use of bootstrap from the old 3 to 5.
And for JS:
Addresses #421