Move GHE requests to UI server#369
Merged
2 commits merged intoclaimed-framework:v0.2.0from Nov 12, 2022
Merged
Conversation
Signed-off-by: Christian Kadner <ckadner@us.ibm.com>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ckadner The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ghost
added
the
Signed-off-by: Christian Kadner <ckadner@us.ibm.com>
Contributor
|
/lgtm |
ghost
merged commit
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The previous commit #368 enabled the MLX-UI to render Markdown files from GitHub Enterprise by using an API token. That token was used on the client web browser where the token could be sniffed out of the web traffic.
This PR moves the code to retrieve the README.md files from the UI client code (
MarkdownViewer.tsx) to the UI server (server.ts) so the API token won't be exposed on the client web browser./cc @Tomcli @yhwang