Conversation
# Conflicts: # package.json # yarn.lock
Member
|
A few notes without scanning the code:
|
Member
It creates the following entry: But it can be extracted into a follow-up issue. |
pomek
reviewed
Dec 1, 2022
lib/commands/status.js
Outdated
| execCommand.execute( getExecData( 'git status --branch --porcelain' ) ) | ||
| execCommand.execute( getExecData( 'git status --branch --porcelain' ) ), | ||
| execCommand.execute( getExecData( 'git describe --abbrev=0 --tags' ) ), | ||
| execCommand.execute( getExecData( 'git tag --sort=committerdate' ) ) |
Member
There was a problem hiding this comment.
"mrgit": "https://github.com/cksource/mrgit.git@latest"
This is crazy. We need to find a new way to extract the latest tag.
martnpaneq
reviewed
Dec 2, 2022
| .then( async () => { | ||
| let checkoutValue; | ||
|
|
||
| if ( !data.repository.tag ) { |
Contributor
There was a problem hiding this comment.
This could be potentially extracted to a local function. There is a very similar code starting from line 211.
Member
Author
There was a problem hiding this comment.
They are both just a bit different, making a function out of the two would require bunch of arguments and would make more mess than anything, not worth it IMO
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Suggested merge commit message (convention)
Feature: Added support for tags. Closes #148.
Additional information
For example – encountered issues, assumptions you had to make, other affected tickets, etc.