Stop forcing pkgconfig static mode in configure - #823
Merged
pabuhler merged 1 commit intoSep 9, 2026
Conversation
Unconditional --static made OpenSSL discovery pull Libs.private into link probes, which fails when those private archives are not installed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #822
configure was rewriting PKG_CONFIG to always pass static mode. That pulls private link flags into the OpenSSL discovery probes, so hosts whose libcrypto.pc names private archives that are not installed (for example Ubuntu with libjitterentropy) fail with cannot find compatible openssl crypto lib.
This change leaves pkgconfig in its normal dynamic mode for discovery. Libs.private in the generated libsrtp3.pc file still receives the resulting LIBS values.
Test plan