Skip to content

Arkime ot updates - #1257

Merged
piercema merged 2 commits into
cisagov:contributor-prsfrom
piercema:arkimeOTUpdates
Oct 20, 2026
Merged

piercema merged 2 commits into
cisagov:contributor-prsfrom
piercema:arkimeOTUpdates

Conversation

@piercema

Copy link
Copy Markdown
Collaborator

Description
What does this pull request change, and why?

Related issue(s)
Link any related issues (e.g., Closes #123).

Type of change

  • Bug fix
  • New feature or enhancement
  • Documentation
  • Other (please describe)

How has this been tested?
Describe how you verified the change, including how you ran Malcolm (ISO, Docker on Linux/Windows/macOS, Kubernetes) and any PCAP or log data you tested with.

Documentation

  • I have updated the documentation where needed, or no update is needed

Was AI used in writing the code, tests, or description for this pull request?

  • No
  • Yes (please describe below)

If yes, describe how: which tool(s), which parts of the change they produced or modified, and how you reviewed and tested that output.

Additional context
Add any other context about the pull request here.

@piercema
piercema merged commit a04d040 into cisagov:contributor-prs Oct 20, 2026
@mmguero mmguero added ics Relating to ICS (Industrial Control Systems) devices arkime Relating to Malcolm's use of Arkime dashboards Relating to Malcolm's OpenSearch Dashboards interface labels Oct 21, 2026
@mmguero mmguero added this to Malcolm Oct 21, 2026
@mmguero mmguero added this to the v26.10.0 milestone Oct 21, 2026
@github-project-automation github-project-automation Bot moved this to Done in Malcolm Oct 21, 2026
mmguero added a commit to mmguero-dev/Malcolm that referenced this pull request Oct 23, 2026
Arkime's sessions template now maps several s7comm, synchrophasor and
c1222 fields as long, and the values normalized into them from Zeek
logs failed to index. Convert them to match Arkime's parsers:

- s7comm.errorCode, s7comm.func, s7comm.opcode: convert from Zeek's hex
  strings; drop zero error codes, as Arkime does
- s7comm.errorClass: map icsnpp-s7comm's class names back to the class
  byte, parsing "Unknown error class-0xNN" values; skip error class and
  code for "Parameter Error" (User-Data errors with no header class),
  which Arkime doesn't record
- s7comm.func: store 0 for User-Data PDUs, since Arkime reads func from
  the parameter head there
- synchrophasor.cmd: map command names back to their CMD codes
- synchrophasor.idcode: take it from data_stream_id (the frame header
  IDCODE) instead of cfg_frame_id/data_frame_id, which are
  analyzer-generated keys linking rows to their detail rows
- split data_rate, data_stream_id and version for TSV logs so
  multi-valued sets index as arrays

The c1222 invocation ID fields are fixed in the parser
(cisagov/icsnpp-c1222#10), and need a build against that version.

See cisagov#986, cisagov#993, cisagov#1257

Signed-off-by: Seth Grover <seth.d.grover@gmail.com>
@mmguero mmguero mentioned this pull request Oct 29, 2026
@mmguero mmguero moved this from Done to Released in Malcolm Oct 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

arkime Relating to Malcolm's use of Arkime dashboards Relating to Malcolm's OpenSearch Dashboards interface ics Relating to ICS (Industrial Control Systems) devices

Projects

Status: Released

Development

Successfully merging this pull request may close these issues.

2 participants