Repository navigation
Arkime ot updates - #1257
Merged
Merged
Arkime ot updates#1257
Conversation
piercema
force-pushed
the
arkimeOTUpdates
branch
from
October 20, 2026 21:48
f00b484 to
ae3133d
Compare
piercema
force-pushed
the
arkimeOTUpdates
branch
from
October 20, 2026 22:25
5a6c3e9 to
87918a9
Compare
mmguero
added a commit
to mmguero-dev/Malcolm
that referenced
this pull request
Oct 23, 2026
Arkime's sessions template now maps several s7comm, synchrophasor and c1222 fields as long, and the values normalized into them from Zeek logs failed to index. Convert them to match Arkime's parsers: - s7comm.errorCode, s7comm.func, s7comm.opcode: convert from Zeek's hex strings; drop zero error codes, as Arkime does - s7comm.errorClass: map icsnpp-s7comm's class names back to the class byte, parsing "Unknown error class-0xNN" values; skip error class and code for "Parameter Error" (User-Data errors with no header class), which Arkime doesn't record - s7comm.func: store 0 for User-Data PDUs, since Arkime reads func from the parameter head there - synchrophasor.cmd: map command names back to their CMD codes - synchrophasor.idcode: take it from data_stream_id (the frame header IDCODE) instead of cfg_frame_id/data_frame_id, which are analyzer-generated keys linking rows to their detail rows - split data_rate, data_stream_id and version for TSV logs so multi-valued sets index as arrays The c1222 invocation ID fields are fixed in the parser (cisagov/icsnpp-c1222#10), and need a build against that version. See cisagov#986, cisagov#993, cisagov#1257 Signed-off-by: Seth Grover <seth.d.grover@gmail.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
What does this pull request change, and why?
Related issue(s)
Link any related issues (e.g.,
Closes #123).Type of change
How has this been tested?
Describe how you verified the change, including how you ran Malcolm (ISO, Docker on Linux/Windows/macOS, Kubernetes) and any PCAP or log data you tested with.
Documentation
Was AI used in writing the code, tests, or description for this pull request?
If yes, describe how: which tool(s), which parts of the change they produced or modified, and how you reviewed and tested that output.
Additional context
Add any other context about the pull request here.