Repository navigation
Simplify installer Yes/No prompt handling - #1255
Open
sylvesterkaczmarek wants to merge 1 commit into
Open
sylvesterkaczmarek wants to merge 1 commit into
sylvesterkaczmarek wants to merge 1 commit into
Conversation
mmguero
force-pushed
the
contributor-prs
branch
from
October 29, 2026 18:01
af68573 to
c6160d8
Compare
Refresh the focused change onto contributor-prs at 7046399. `python -m pytest -q shared/tests/test_malcolm_yes_or_no.py`: **28 passed**. Python compilation passes; the pre-existing unrelated Ruff `self.run_process` finding is unchanged. No interactive installer deployment was run.
sylvesterkaczmarek
force-pushed
the
fix/765-refactor-yesno-20261016
branch
from
November 6, 2026 07:49
0fc55d4 to
37de6a0
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Maintenance update on 6 November 2026
Refreshed onto
contributor-prsat7046399bafter the integration branch history changed. This PR now contains its 2-file topic change in one commit.python -m pytest -q shared/tests/test_malcolm_yes_or_no.py: 28 passed. Python compilation passes; the pre-existing unrelated Ruffself.run_processfinding is unchanged. Git whitespace checks pass.No interactive installer deployment was run.
Earlier validation counts below record the original branch state. ChatGPT assisted with this refresh, corrections and validation.
Summary
Refs #765.
Reduce cyclomatic complexity in the installer's
YesOrNoprompt routine without changing its public API or prompt behaviour. Radon grade: E (39) → B (6).Validation
python -m pytest -q shared/tests/test_malcolm_yes_or_no.py: 28 passed.python -m pytest -q shared/tests: 659 passed, 6 skipped, 31 subtests passed.git diff --check: passed.Tested offline; no live installer/dialog interaction or production deployment.
Scope
Targets
contributor-prs. Only the #765YesOrNoitem is addressed; the broader complexity review remains open.