Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Warn when the full Malcolm stack is configured for a local host whose detected physical RAM is below Malcolm's documented 24 GiB minimum. This follows the maintainer's requested direction in #483 rather than changing Java heap defaults (the smaller-heap approach in #1188 was deliberately rejected).
/proc/meminfoindicates no configured swap. If swap is configured, clarify that swap is not a replacement for RAM.Related issue(s)
Addresses #483. This is intentionally separate from the rejected heap-reduction PR #1188.
Type of change
How has this been tested?
8 focused tests pass, covering 4–23 GiB hosts, 24 GiB and larger hosts, no swap / swap present / unknown, missing and malformed
/proc/meminfo, interactive message display, silent mode, Hedgehog/Kubernetes exclusions, and confirmation that heap defaults are unchanged. The warning is log-only and does not invoke configuration mutation methods.The repository's larger installer unit suite was also run locally: 67 tests, 4 failures and 6 errors. These are the same 4 failures and 6 errors reproduced on unchanged upstream
main(59 tests) in pre-existing configuration round-trip, Traefik, and validation tests; the 8 added cases pass. Static correctness checks andgit diff --checkpassed (excluding longstandinginstall.pystar-import/E402 warnings). No Docker/ISO or Kubernetes deployment was run; this is CPU-only, dependency-backed testing on macOS.Documentation
docs/system-requirements.md.Was AI used in writing the code, tests, or description for this pull request?
ChatGPT assisted with source review, drafting the preflight implementation, unit tests, and this description. I inspected the changes, reproduced the original behaviour and ran the tests and static checks reported above.
Additional context
This intentionally does not change or enforce host hardware requirements. The warning is informational, and an undersized evaluation system remains unsupported for the full stack.