Repository navigation
Conversation
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The PCAP watcher derives automatic metadata tags by splitting uploaded filenames and removing recognized capture/log format tokens. The filter omits the PCAPNG extension, even though the same module recognizes application/x-pcapng. PCAPNG uploads consequently acquire an unintended pcapng metadata tag.
Add pcapng to the existing case-insensitive exact-token format exclusions. Preserve all other filename, path, and user-defined tag behavior, including substrings such as pcapnglab.
Related issue(s)
None; independently reproduced against the latest contributor-prs code, with no overlapping open PR.
Type of change
How has this been tested?
This is focused metadata testing, not an end-to-end PCAP ingest or Malcolm Docker/ISO deployment.
Documentation
Was AI used in writing the code, tests, or description for this pull request?
Additional context
Based directly on contributor-prs as requested by Malcolm maintainers. No new dependencies or runtime settings.