Repository navigation
Prune at configured disk limits and support paths with spaces - #1231
Merged
mmguero merged 3 commits intoOct 13, 2026
Conversation
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
shared/bin/prune_files.sh documents that pruning begins at or above the
configured disk-usage percentage or path-size threshold and stops only after
usage drops below both limits. The implementation uses strict greater-than
comparisons, so exact-boundary usage never triggers cleanup or can stop early.
The script also expands the -p prune path without quoting it when changing
directories. A valid capture or log directory containing spaces fails with
a path error instead of being pruned.
Fix
further pruning is needed.
and independent percent/size threshold selection unchanged.
Tests
Four sandboxed integration tests exercise the real shell script with mock
disk-usage and file-listing tools. Files are only created and deleted inside
temporary directories. The cases cover paths containing spaces, usage exactly
equal to the percent threshold, size exactly equal to the GB threshold,
and no cleanup below the threshold.
The original upstream script fails three cases and passes the below-threshold
control. With the fix, all four cases pass.
git diff --check passed.
were touched.