Skip to content

Align Malcolm local account management with the landing UI - #1216

Merged
mmguero merged 1 commit into
cisagov:contributor-prsfrom
sylvesterkaczmarek:feature/531-match-account-management-ui
Oct 12, 2026
Merged

mmguero merged 1 commit into
cisagov:contributor-prsfrom
sylvesterkaczmarek:feature/531-match-account-management-ui

Conversation

@sylvesterkaczmarek

Copy link
Copy Markdown
Contributor

Summary

Addresses #531 by bringing Malcolm's embedded local account-management interface closer to the landing and extracted-files pages while retaining the existing htadmin application and Bootstrap 3 workflows.

  • Add a consistent Malcolm/CISA header and navigation using the landing page's CISA SVG and brand colors.
  • Style account forms, focus rings, panels and buttons with a responsive Malcolm theme layered after htadmin's Bootstrap styles.
  • Add a shared Malcolm footer linking to the home page, documentation, service readiness, and GitHub. Display the installed version when supplied.
  • Preserve administrator login, logout, and account self-service navigation based on authentication state.
  • Reuse existing PHP include override points (head.php, nav.php, footer.php) instead of vendoring the external htadmin implementation.
  • Escape the configured page title before inserting it into HTML.

Verification

  • 10 offline regression tests passed, including PHP template rendering for authenticated/unauthenticated navigation, accessible branding, asset wiring and resource links.
  • php -l passed for all three PHP templates.
  • Ruff, Black and Git diff checks passed.
  • Full htadmin container rendering and browser cross-device screenshots have not been run; visual and accessibility QA are recommended on the finished image.

mmguero added a commit to mmguero-dev/Malcolm that referenced this pull request Oct 12, 2026
cisagov#1216

Signed-off-by: Seth Grover <seth.d.grover@gmail.com>
@mmguero mmguero self-assigned this Oct 12, 2026
@mmguero mmguero added UI Relating to general UI experience auth Related to Malcolm's authentication and/or user management labels Oct 12, 2026
@mmguero mmguero added this to the v26.10.0 milestone Oct 12, 2026
mmguero added a commit to mmguero-dev/Malcolm that referenced this pull request Oct 12, 2026
cisagov#1216

Signed-off-by: Seth Grover <seth.d.grover@gmail.com>
@mmguero mmguero added this to Malcolm Oct 12, 2026
@mmguero
mmguero changed the base branch from main to contributor-prs October 12, 2026 20:19
@mmguero
mmguero merged commit f3ae914 into cisagov:contributor-prs Oct 12, 2026
@github-project-automation github-project-automation Bot moved this from Review to Done in Malcolm Oct 12, 2026
mmguero added a commit that referenced this pull request Oct 12, 2026
Signed-off-by: Seth Grover <seth.d.grover@gmail.com>
mmguero added a commit that referenced this pull request Oct 12, 2026
Signed-off-by: Seth Grover <seth.d.grover@gmail.com>
piercema pushed a commit to piercema/Malcolm that referenced this pull request Oct 20, 2026
piercema pushed a commit to piercema/Malcolm that referenced this pull request Oct 20, 2026
piercema pushed a commit to piercema/Malcolm that referenced this pull request Oct 20, 2026
piercema pushed a commit to piercema/Malcolm that referenced this pull request Oct 20, 2026
@mmguero mmguero mentioned this pull request Oct 29, 2026
@mmguero mmguero moved this from Done to Released in Malcolm Oct 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

auth Related to Malcolm's authentication and/or user management UI Relating to general UI experience

Projects

Status: Released

Development

Successfully merging this pull request may close these issues.

2 participants