Repository navigation
Conversation
Signed-off-by: Sylvester Kaczmarek <16242628+sylvesterkaczmarek@users.noreply.github.com>
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #1175.
Recursively collect descendants of mapping
propertiesusing qualified field names. Previously implicit objects were skipped entirely and explicit object/nested fields exposed only their parent entry.Existing flat/dotted fields, type conversion, debug source metadata, explicit parent entries, catalogue cleanup and component lookup behavior are retained. Multi-fields under
fields, template precedence and live-index discovery are outside this change.Testing
python -m pytest -q api/tests/test_nested_mapping_fields.py13 focused tests passed; 12 fail on unchanged main. Coverage includes implicit objects, explicit object/nested mappings, multiple nesting levels, dotted siblings, empty objects, debug metadata, the checked-in filescan/Suricata/common component templates, and real Flask
/fieldsrequests.The API imports normally with credentials and HTTP transport isolated. Metadata responses are local fixtures; no live OpenSearch/Dashboards service, credentials or listening server was used.
89 tests passed in an isolated combined check containing these three fixes and the current #1155, #1166 and #1174 changes. That run includes the existing timezone and worker-cancellation regressions; the separate chunk-size suite was not rerun. No earlier production changes are included in this PR.
Tested on macOS with Python 3.12 and the pinned AnyIO 4.14.2. New-test formatting, scoped syntax/lint checks and
git diff --checkpass. No dependency or workflow changes. Full Malcolm deployment testing was not run.