Repository navigation
Report Supervisor failures correctly in filescan health checks - #1162
Merged
Conversation
Signed-off-by: Sylvester Kaczmarek <16242628+sylvesterkaczmarek@users.noreply.github.com>
Signed-off-by: Sylvester Kaczmarek <16242628+sylvesterkaczmarek@users.noreply.github.com>
This was referenced Oct 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #1159.
Match Supervisor states using the lowercase values already stored in Program.state, and read the documented
stopfield when recording an exited process. This activates the existing error-state and exit-code checks instead of silently treating optional failed processes as healthy.The autostart policy, allowed exit codes, response schema and HTTP status behavior are unchanged. Process/config pairing and readiness policy are outside this correction.
Testing
python -m pytest -q filescan/python-filescan/tests/test_health_process_states.py17 focused tests passed; 10 fail on unchanged source. Real Flask requests exercise FATAL/BACKOFF/UNKNOWN, allowed and unexpected exit codes, start/stop metadata, running and optional-process controls, aggregate health and RPC errors.
The external Supervisor interface is replaced before module import. No live XML-RPC service, scanner process, socket listener or container was started. Tests ran on macOS with Python 3.12; full deployment testing was not run.
New-test formatting, syntax checks and
git diff --checkpass. No dependency, workflow or version changes.Thanks for taking a look.