Skip to content

Idea: Terminate ./script/start once Malcolm has started properly. #240

Closed

Description

@Njinx

I find ./script/start a bit clunky because you never really know when Malcolm is finished starting and able to be interacted with. Would you be open to changing the default behavior (or creating a setting) so that ./scripts/start will terminate once Malcolm is fully started? I'd be happy to try and implement this myself, but I'd like to know if anybody is opposed to this beforehand.

Activity

  1. changed the title [-]Terminate `./script/start` once Malcolm has started properly.[/-] [+]Idea: Terminate `./script/start` once Malcolm has started properly.[/+] on Feb 21, 2023
  2. mmguero commented on Feb 22, 2023

    @mmguero
    Collaborator

    yeah that's a cool idea. "Fully started" could depend on your opinion of what that means, but generally for me I look for:

    malcolm-logstash-1  | [2022-07-27T20:27:52,056][INFO ][logstash.agent           ] Pipelines running {:count=>6, :running_pipelines=>[:"malcolm-input", :"malcolm-output", :"malcolm-beats", :"malcolm-suricata", :"malcolm-enrichment", :"malcolm-zeek"], :non_running_pipelines=>[]}
    

    The "Pipelines running" script from logstash is usually the last indication that Malcolm is fully ready to process data.

    You're welcome to take a stab at it, or I think I could take care of it this Friday once I get back from the travel I'm on.

    Cheers

  3. self-assigned this
    on Feb 22, 2023
  4. mmguero commented on Mar 8, 2023

    @mmguero
    Collaborator

    Going into v23.03.0 release forthcoming

  5. added 2 commits that reference this issue on Mar 8, 2023
  6. added a commit that references this issue on Feb 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

enhancementNew feature or request

Type

No type

Fields

No fields configured for issues without a type.

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions