[wip] hea integration (for GAM fit)#21
Open
huangziwei wants to merge 29 commits into
Open
Conversation
…sion preparations
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
in #18 I added
heaas dependency forLCRegression, which just a wrapper aroundlm()and some aesthetics on top. Asgamalso reached some maturity, it can actually be used as an "automatic harmonic-order selector" (withs(bs='cc')), instead of guessing and hand-rolling how many combos of cos/sin should be used. Plus,heaalso offers a full set of tidyverse data frame manipulation + fluent API ofggplotwhich can be used for I/O, data transformation, and plotting, but that's for later.I am not sure if this is a good call yet, as
heais still a toy project (mostly Agent-driven, unlikepycircstat2which was coded by hand since 2022; but yes, I also have been using more and more LLMs on this codebase; the difference is: agents work on the code I wrote before, mostly review and fix bugs; forhea, it's 99% generated). I think I need to put this here to be transparent.But here's what you can get from
hea:which will output:
and you can get do a GAM fit:
The plan for this RP, to the very least, is to integrate
gamdirectly intoLCRegression(). It can be easily (likely) extended to CCRegression. But for CLRegression, we also need to work on some refactoring of the distributions (to fit thehea.familystandard).