Skip to content

🚸 Remove click-on-empty-to-import (Closes #1840) - #1842

Merged
gwennlbh merged 1 commit into
mainfrom
remove-click-on-empty-to-import
Jul 6, 2026
Merged

gwennlbh merged 1 commit into
mainfrom
remove-click-on-empty-to-import

Conversation

@gwennlbh

@gwennlbh gwennlbh commented Jul 6, 2026 •

Copy link
Copy Markdown
Member

Closes #1840
[Mon Jul 6 15:27:47 UTC 2026] Downloading the Android app preview from Diawi:

QR code

https://i.diawi.com/qCLXSF

@github-actions

github-actions Bot commented Jul 6, 2026

Copy link
Copy Markdown
Contributor

✅ Coverage is up by 0.06% (from 55.64% to 55.7%)

@github-actions

github-actions Bot commented Jul 6, 2026

Copy link
Copy Markdown
Contributor

Bundle Stats

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count Total bundle size % Changed
288 48.43 MB → 48.43 MB (-266 B)
12.33 MB → 12.33 MB (gzip)
-0.00%
Changeset
File Δ Size
tabbable/dist/index.esm.js 🆕 +5.17 kB 0 B → 5.17 kB
candidates/+page.svelte 🆕 +1.04 kB 0 B → 1.04 kB
Content/Content.svelte 🆕 +720 B 0 B → 720 B
metadata/MetadataTypeswitch.svelte 🆕 +577 B 0 B → 577 B
Overlay/Overlay.svelte 🆕 +496 B 0 B → 496 B
utils/dom.js 🆕 +119 B 0 B → 119 B
scroll-lock/scroll-lock.svelte 🆕 +96 B 0 B → 96 B
errors.js 📈 +822 B (+428.13%) 192 B → 1014 B
warnings.js 📈 +554 B (+344.10%) 161 B → 715 B
index.js 📈 +207 B (+279.73%) 74 B → 281 B
log.js 📈 +916 B (+263.22%) 348 B → 1.23 kB
utils.js 📈 +826 B (+69.06%) 1.17 kB → 1.97 kB
AreaObservations.svelte 📉 -50 B (-0.86%) 5.68 kB → 5.63 kB
runtime.js 📉 -116 B (-2.11%) 5.37 kB → 5.26 kB
(sidepanel)/import/+page.svelte 📉 -100 B (-4.88%) 2 kB → 1.91 kB
implementation.js 📉 -51 B (-6.63%) 769 B → 718 B
dragselect.svelte.js 📉 -116 B (-7.88%) 1.44 kB → 1.33 kB
polyfill.js 📉 -31 B (-15.50%) 200 B → 169 B
shim.js 📉 -97 B (-50.00%) 194 B → 97 B
string.js 📉 -8.29 kB (-91.43%) 9.06 kB → 795 B
index.esm.js 🔥 -5.17 kB (-100%) 5.17 kB → 0 B
ulid/dist/browser/index.js 🔥 -1.73 kB (-100%) 1.73 kB → 0 B
libraw-wasm/dist/index.js 🔥 -1.52 kB (-100%) 1.52 kB → 0 B
legacy-client.js 🔥 -1.04 kB (-100%) 1.04 kB → 0 B
Content.svelte 🔥 -720 B (-100%) 720 B → 0 B
MetadataTypeswitch.svelte 🔥 -577 B (-100%) 577 B → 0 B
Overlay.svelte 🔥 -496 B (-100%) 496 B → 0 B
scroll-lock.svelte 🔥 -96 B (-100%) 96 B → 0 B
View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

No assets were bigger

Smaller

Asset File Size % Changed
_app/immutable/chunks/Ds0pp4AA.js 25.76 kB → 25.6 kB (-166 B)
10.2 kB → 10.13 kB (gzip)
-0.63%
_app/immutable/nodes/16.oUo8SNJj.js 3.25 kB → 3.16 kB (-100 B)
1.65 kB → 1.62 kB (gzip)
-3.00%

@gwennlbh
gwennlbh temporarily deployed to 1842: E2E tests July 6, 2026 13:54 — with GitHub Actions Inactive
@github-actions

github-actions Bot commented Jul 6, 2026 •

Copy link
Copy Markdown
Contributor

Performance changes with main

Browser Test Metric Head Base Change
webkit startup @blank Total 9 094 ms 9 151,8 ms
startup Total 8 556 ms 8 276,4 ms
chromium startup @blank DOM 633,74 605,54
Load 634,02 605,78
Bytes 8 680 153 8 663 688
LCP 14 583,2 14 075,2
TBT 2 749,6 2 681
CLS 0,17 0,21 🔻-21,19
Total 14 660,6 ms 14 064 ms
startup DOM 440,22 534,48 🔻-17,64
Load 440,52 534,66 🔻-17,61
Bytes 19 849 241,2 19 769 949
LCP 6 952,8 6 967,2
TBT 1 893,6 1 909,2
CLS 0,09 0,15 🔻-39,71
Total 7 222,6 ms 7 272,2 ms

Total: total, DOM: domCompleteTiming, Load: pageloadTiming, Bytes: totalBytes, LCP: largestContentfulPaint, TBT: totalBlockingTime, CLS: cumulativeLayoutShift,

gwennlbh pushed a commit that referenced this pull request Aug 3, 2026
##### [v1.50.0](https://github.com/toss/es-toolkit/blob/HEAD/CHANGELOG.md#Version-v1500)

Released on July 24th, 2026.

- Added the `es-toolkit/types` entrypoint: a declaration-only module of compile-time
  type utilities TypeScript lacks natively — `ValueOf`, `Simplify`, `Writable`,
  `NonEmptyArray`, `DeepPartial`, and `DeepReadonly`. (\[[#1818](toss/es-toolkit#1818)])
- Added `flow` to `es-toolkit/fp`, a reusable data-last composition built on `pipe`. (\[[#1812](toss/es-toolkit#1812)])

The following bring `es-toolkit/compat` closer to Lodash. Behavior for the affected
edge cases now matches Lodash, so results may differ if you relied on the previous output.

- Fixed `compat/intersectionBy` to dedupe a single array (including by the iteratee)
  and to keep results consistent with Lodash. (\[[#1935](toss/es-toolkit#1935)])

- Fixed `compat/findIndex` and `compat/findLastIndex` to coerce a `NaN` `fromIndex`
  to `0` and to convert `fromIndex` to an integer. (\[[#1828](toss/es-toolkit#1828)], \[[#1834](toss/es-toolkit#1834)], \[[#1938](toss/es-toolkit#1938)])

- Fixed `compat/lastIndexOf` to coerce `fromIndex` like Lodash. (\[[#1832](toss/es-toolkit#1832)])

- Fixed `compat/every` to treat a falsy, non-nullish `doesMatch` as a `_.property`
  shorthand instead of identity. (\[[#1940](toss/es-toolkit#1940)])

- Fixed `compat/nth` to support string inputs. (\[[#1833](toss/es-toolkit#1833)])

- Fixed `compat/inRange` to not throw on a lone negative bound. (\[[#1835](toss/es-toolkit#1835)])

- Fixed `compat/toArray` to convert `Set`s to arrays like Lodash. (\[[#1840](toss/es-toolkit#1840)])

- Fixed `compat/values` to treat sparse array holes as `undefined`. (\[[#1894](toss/es-toolkit#1894)])

- Fixed `compat/maxBy` and `compat/minBy` to restore Lodash-compatible comparison. (\[[#1893](toss/es-toolkit#1893)])

- Fixed `compat/includes` to exclude the `length` property when matching array-like values. (\[[#1886](toss/es-toolkit#1886)])

- Fixed the case functions to split ordinal numbers like Lodash, and to count string
  size and padding by code points for multi-byte characters. (\[[#1836](toss/es-toolkit#1836)], \[[#1852](toss/es-toolkit#1852)], \[[#1853](toss/es-toolkit#1853)])

- Fixed `compat/unset` to not treat an own literal dotted key as a deep path. (\[[#1808](toss/es-toolkit#1808)])

- Moved `compat/flattenDepth`'s flattening logic out of `flatten`. (\[[#1847](toss/es-toolkit#1847)])

- Restored the standalone `eq` and `templateSettings` entry points. (\[[#1895](toss/es-toolkit#1895)])

- Fixed `deburr` to remove all combining diacritical marks, matching Lodash. (\[[#1807](toss/es-toolkit#1807)])

- Fixed `partition` to accept any predicate return value, like `Array.prototype.filter`. (\[[#1937](toss/es-toolkit#1937)])

- Fixed `has` and `hasIn` to prioritize nullish literal keys over paths. (\[[#1810](toss/es-toolkit#1810)])

- Fixed `invokeMap` to normalize a string path via `toPath` for `this` binding. (\[[#1814](toss/es-toolkit#1814)])

- Fixed `isDeepKey` to detect deep keys with stricter patterns. (\[[#1621](toss/es-toolkit#1621)])

- Fixed `unzipWith` to return an empty array instead of throwing on empty input. (\[[#1816](toss/es-toolkit#1816)])

- Improved documentation, JSDoc accuracy, and internal refactoring across `compat`
  and `fp`. (\[[#1817](toss/es-toolkit#1817)], \[[#1820](toss/es-toolkit#1820)], \[[#1822](toss/es-toolkit#1822)], \[[#1823](toss/es-toolkit#1823)], \[[#1825](toss/es-toolkit#1825)], \[[#1829](toss/es-toolkit#1829)], \[[#1830](toss/es-toolkit#1830)], \[[#1842](toss/es-toolkit#1842)],
  \[[#1845](toss/es-toolkit#1845)], \[[#1851](toss/es-toolkit#1851)], \[[#1858](toss/es-toolkit#1858)], \[[#1867](toss/es-toolkit#1867)], \[[#1879](toss/es-toolkit#1879)])

We sincerely thank [@Antoliny0919](https://github.com/Antoliny0919), [@raon0211](https://github.com/raon0211), [@dayongkr](https://github.com/dayongkr), [@spokodev](https://github.com/spokodev), [@sarathfrancis90](https://github.com/sarathfrancis90),
[@mayur-shenoy](https://github.com/mayur-shenoy), [@mahirhir](https://github.com/mahirhir), [@kojesung](https://github.com/kojesung), [@Hprogram](https://github.com/Hprogram), [@BangDori](https://github.com/BangDori), and everyone else who
contributed. We appreciate your great efforts!

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@gwennlbh
gwennlbh deleted the remove-click-on-empty-to-import branch October 12, 2026 15:00

This branch was successfully deployed

7 active deployments
1842: E2E tests — 84fc3896 Deployed Jul 6, 2026 by gwennlbh via E2E / Upload report / Deploy #8535
1842: App preview — 84fc3896 Deployed Jul 6, 2026 by gwennlbh via PR Preview / Deploy / Deploy #8535
1842: Bundle analyzer — 84fc3896 Deployed Jul 6, 2026 by gwennlbh via Bundle size / Breakdown site / Deploy #8515
1842: Unit tests — 84fc3896 Deployed Jul 6, 2026 by gwennlbh via Unit tests / Test report / Deploy #8515
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

remove click-on-empty-to-import

1 participant