Repository navigation
Optional fields for get and query - #845
Closed
jeffchuber wants to merge 1 commit into
Closed
jeffchuber wants to merge 1 commit into
jeffchuber wants to merge 1 commit into
Conversation
Reviewer ChecklistPlease leverage this checklist to ensure your code review is thorough before approving Testing, Bugs, Errors, Logs, Documentation
System Compatibility
Quality
|
Contributor
|
Offline discussion with @atroyn - this is not the approach we want so closing this out. |
4 of 7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR aims to clear up communication around what data users get back when using
.getand.querySpecifically this issue: https://docs.trychroma.com/troubleshooting#using-get-or-query-embeddings-say-none
This PR updates

getandqueryto only send back the fields you request. To add extra communication, we pass back a new field calledincluded_fieldsthat tells you what was included. This is added because we have defaults that a user may not be familiar with.If we like this direction: I will continue on and add tests for it and make sure it operates well with the JS client.
NOTE: I expect tests to fail right now!