Repository navigation
update dependency nan@2.0.5 to nan@2.3.5 - #159
Merged
Merged
Conversation
Closed
|
This would fix many issues if published. |
|
👍 |
|
Also, would be good to update to the latest WinPty 0.4.0. Here are the build logs:
|
y13i
changed the title
|
@chjj did you test this PR? I see that you have released new version 0.3.1. I made a few tests and 2.3.5 NAN doesn't compatible with obsolete WinPty. It seems that this package now is broken for Windows users. See log: http://pastebin.com/UQQJZ0HE |
|
In this case, need to update WinPty to 0.4.0 and use new WinPty API |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Looks like nan@2.0.5 has a problem with recent versions of V8.