Repository navigation
Option/Alt + click opens a link in split view - #2
Closed
chirivelli wants to merge 1 commit into
Closed
chirivelli wants to merge 1 commit into
chirivelli wants to merge 1 commit into
Conversation
Shift/Glance-style modifier clicks can now open a link beside the current tab. Option/Alt + click splits with the current tab unless Glance is enabled and bound to Alt, in which case Glance keeps the gesture. Co-authored-by: Sathwik Chirivelli <chirivelli@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Option/Alt + click on a link now opens it in a split with the current tab, analogous to Glance’s modifier-click.
Collision check
This can be done, with one real overlap:
preventDefaults, so it replaces save-link-as for that gesture. Disable withzen.splitView.alt-click-open.zen.splitView.enable-tab-click-split) is unchanged; that only applies to the tab strip, not in-page links.Behavior
Pref
zen.splitView.alt-click-open(defaulttrue).Tests:
src/zen/tests/split_view/browser_split_view_alt_click.js.