feat: delete 1D signal on backspace key press#4003
Merged
hamed-musallam merged 3 commits intomainfrom Mar 9, 2026
Merged
Conversation
Deploying nmrium with
|
| Latest commit: |
7b23f88
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://f1022f0f.nmrium.pages.dev |
| Branch Preview URL: | https://hover-signal-and-delete.nmrium.pages.dev |
Member
|
I can’t make it work. I’m not sure what I’m doing wrong. Could it be a backspace/delete problem?
|
hamed-musallam
force-pushed
the
hover-signal-and-delete
branch
from
6743797 to
19eda01
Compare
lpatiny
approved these changes
Mar 5, 2026
Member
lpatiny
left a comment
lpatiny
left a comment
There was a problem hiding this comment.
It works as I expect. Thanks !
hamed-musallam
force-pushed
the
hover-signal-and-delete
branch
from
5c95a57 to
7b23f88
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.