Skip to content

fix: margin for peaks label should not have max in general form#4038

Merged
Sebastien-Ahkrin merged 3 commits intomainfrom
4015-peaks-label---margin-top
Mar 6, 2026
Merged

fix: margin for peaks label should not have max in general form#4038
Sebastien-Ahkrin merged 3 commits intomainfrom
4015-peaks-label---margin-top

Conversation

@Sebastien-Ahkrin
Copy link
Copy Markdown
Collaborator

Closes: #4015

@Sebastien-Ahkrin Sebastien-Ahkrin linked an issue Mar 5, 2026 that may be closed by this pull request
@cloudflare-workers-and-pages
Copy link
Copy Markdown

cloudflare-workers-and-pages bot commented Mar 5, 2026

Deploying nmrium with  Cloudflare Pages  Cloudflare Pages

Latest commit: a95309f
Status: ✅  Deploy successful!
Preview URL: https://02f3394e.nmrium.pages.dev
Branch Preview URL: https://4015-peaks-label---margin-to.nmrium.pages.dev

View logs

Comment thread src/component/modal/setting/tanstack_general_settings/tabs/general_tab.tsx Outdated
@Sebastien-Ahkrin
Copy link
Copy Markdown
Collaborator Author

I was trying to fix something, but i don't know if we easily can. When we save the form, the placement on the graph is not reloaded .. i think its a bit confusing .. what about you ?

@Sebastien-Ahkrin Sebastien-Ahkrin changed the title fix: margin for peaks label should be .1 step fix: margin for peaks label should be 1 step without max Mar 6, 2026
@Sebastien-Ahkrin
Copy link
Copy Markdown
Collaborator Author

Ok, after some messages with theotime. Step 1 by 1 looks to be the better (for PX). Then, i removed the "max" since, when you move the element inside the graph (and not in the form) values like "150" are set in the form.

Next step, is to change the entire calculation to be in percentage.
Plus, should we try to update the graph margin, at the same time than when you save the form ?

@targos
Copy link
Copy Markdown
Member

targos commented Mar 6, 2026

Plus, should we try to update the graph margin, at the same time than when you save the form ?

Yes. It's a bug that it doesn't update when you change the form.

@Sebastien-Ahkrin
Copy link
Copy Markdown
Collaborator Author

Plus, should we try to update the graph margin, at the same time than when you save the form ?

Yes. It's a bug that it doesn't update when you change the form.

Ok, then i created a new issue.
This one is only about removing the max on the form then

@Sebastien-Ahkrin Sebastien-Ahkrin requested a review from targos March 6, 2026 10:25
@Sebastien-Ahkrin Sebastien-Ahkrin marked this pull request as ready for review March 6, 2026 10:25
@Sebastien-Ahkrin Sebastien-Ahkrin changed the title fix: margin for peaks label should be 1 step without max fix: margin for peaks label should not have max in general form Mar 6, 2026
@Sebastien-Ahkrin Sebastien-Ahkrin merged commit 3620893 into main Mar 6, 2026
12 checks passed
@Sebastien-Ahkrin Sebastien-Ahkrin deleted the 4015-peaks-label---margin-top branch March 6, 2026 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Peaks label - margin top

2 participants