Repository navigation
fix(collection): hide redundant individual selector - #429
Merged
Merged
Conversation
8 of 10 tasks
cte13
added a commit
to cte13/PokeTokenBar-iOS
that referenced
this pull request
Oct 10, 2026
chore: sync fork with upstream (v2.5.5, chattymin#321–chattymin#429)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Hide the individual selector when the viewed species/form/appearance has only one matching individual. Its profile, stats and moves remain visible. Two or more matching individuals keep the selector; an empty match keeps the species preview.
Validation:
swift build --disable-sandbox -j 2passed.swift test --disable-sandbox -j 2 --filter 'IndividualPickerRenderingTests|PokemonProfileMigrationTests'passed all 10 tests on the current main-based branch. The mounted native-view regression checks no menu for one individual and one menu with two items for two individuals. Restoring the original condition made the single-individual assertion fail. The full test suite was not run.Type of change
UI changes
Sample-data renders of the production detail view, captured only around the selector and profile. No sprites or user save data are included.
With two individuals, the selector remains available:
Checklist
swift buildandswift testpass locally