Skip to content

fix(collection): hide redundant individual selector - #429

Merged
chattymin merged 2 commits into
mainfrom
codex/individual-picker-ready
Oct 6, 2026
Merged

chattymin merged 2 commits into
mainfrom
codex/individual-picker-ready

Conversation

@chattymin

Copy link
Copy Markdown
Owner

Summary

Hide the individual selector when the viewed species/form/appearance has only one matching individual. Its profile, stats and moves remain visible. Two or more matching individuals keep the selector; an empty match keeps the species preview.

Validation: swift build --disable-sandbox -j 2 passed. swift test --disable-sandbox -j 2 --filter 'IndividualPickerRenderingTests|PokemonProfileMigrationTests' passed all 10 tests on the current main-based branch. The mounted native-view regression checks no menu for one individual and one menu with two items for two individuals. Restoring the original condition made the single-individual assertion fail. The full test suite was not run.

Type of change

  • Bug fix
  • New feature
  • Refactor / cleanup
  • Documentation
  • Other:

UI changes

Sample-data renders of the production detail view, captured only around the selector and profile. No sprites or user save data are included.

Before — one individual After — one individual
Before — sample-data render After — sample-data render

With two individuals, the selector remains available:

Two individuals — sample-data render

Checklist

  • swift build and swift test pass locally
  • PR title follows Conventional Commits and title/description are written in English
  • UI changes include embedded images (before/after for existing screens; image of a new screen), or there is no visible UI change
  • No copyrighted assets, secrets, or private tooling references are committed (see CONTRIBUTING)
  • Tests were added or updated for this change

@chattymin
chattymin merged commit c328d5c into main Oct 6, 2026
2 checks passed
@chattymin
chattymin deleted the codex/individual-picker-ready branch October 6, 2026 02:48
cte13 added a commit to cte13/PokeTokenBar-iOS that referenced this pull request Oct 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant