Skip to content

Pin Shedinja's HP to 1 - #422

Merged
chattymin merged 1 commit into
chattymin:mainfrom
Borisserz:fix/shedinja-hp
Oct 5, 2026
Merged

chattymin merged 1 commit into
chattymin:mainfrom
Borisserz:fix/shedinja-hp

Conversation

@Borisserz

Copy link
Copy Markdown
Contributor

Summary

Fixes #421. In the main series Shedinja (#292) always has 1 HP. PokemonStatCalculator used the generic HP formula for every species, so the Pokédex stats section showed it with 11 to about 125 HP depending on level. Shedinja is reachable through Nincada's evolution branch.

HP is now pinned to 1 for species 292. Other stats and every other species are unchanged.

Type of change

  • Bug fix
  • New feature
  • Refactor / cleanup
  • Documentation
  • Other:

UI changes

Before After
Shedinja stats at Lv50: HP about 67 Shedinja stats: HP 1

Validation

  • New PokemonProfileLogicTests.testShedinjaAlwaysHasOneHP: HP is 1 at Lv1, Lv50 and Lv100, attack still follows the generic formula, and a non-Shedinja species with base HP 1 keeps the generic formula. On unfixed main it fails with 3 failures (11, 67 and 125 HP).
  • Full swift test: 1385 tests, 0 failures (17 skipped, as on main).
  • Added a defect-log entry.

Checklist

  • swift build and swift test pass locally
  • PR title and description are written in English
  • UI changes are described above (before/after — images optional)
  • No copyrighted assets, secrets, or private tooling references are committed (see CONTRIBUTING)
  • Tests were added or updated for this change

@chattymin
chattymin merged commit fad8f1a into chattymin:main Oct 5, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Shedinja's stats show dozens of HP instead of always 1

2 participants