Repository navigation
Pin Shedinja's HP to 1 - #422
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #421. In the main series Shedinja (#292) always has 1 HP.
PokemonStatCalculatorused the generic HP formula for every species, so the Pokédex stats section showed it with 11 to about 125 HP depending on level. Shedinja is reachable through Nincada's evolution branch.HP is now pinned to 1 for species 292. Other stats and every other species are unchanged.
Type of change
UI changes
Validation
PokemonProfileLogicTests.testShedinjaAlwaysHasOneHP: HP is 1 at Lv1, Lv50 and Lv100, attack still follows the generic formula, and a non-Shedinja species with base HP 1 keeps the generic formula. On unfixedmainit fails with 3 failures (11, 67 and 125 HP).swift test: 1385 tests, 0 failures (17 skipped, as onmain).Checklist
swift buildandswift testpass locally