Repository navigation
fix: 출시 전 감사 반영 — 언어 로케일화·알림 지연·첫실행 안내·상태손상 방어 - #41
Merged
Merged
Conversation
MVP 출시 감사(정합성/UX 2렌즈)에서 나온 launch-blocking/high 항목 수정. BLOCKER — 기본 언어 한국어 고정: - AppLanguage.systemDefault(시스템 선호 언어 유추, ko/ja 외 전부 en) 신규 설치 기본값으로. 기존 사용자는 저장된 언어 그대로. 글로벌 출시에서 영어권 유저가 한국어 UI 보는 문제 제거. HIGH — 알림 권한 콜드 프롬프트: - 기동 즉시 요청하던 것을 팝오버 첫 오픈(사용자 의도)으로 지연(멱등). 거부율↓·첫인상↑. HIGH — 첫 실행 "아무 일도 안 일어남" 오해: - 알 상태(적립 0)에 한 줄 안내 추가(로컬 로그 기반·~5M 부화). eggFirstRunHint ko/en/ja. SHOULD-FIX(정합성) — 상태 파일 손상 방어: - MonState.currentID 가 pathIDs 비면 baseID 폴백(렌더마다 읽힘 → out-of-bounds 크래시 방지). - 디코드 시 빈 pathIDs 거부 → CompanionState 디코드 실패 → load() 가 기본 알로 폴백. 폴리시 — rarity 배지 현지화: - 홈/도감 배지가 rawValue(영문 고정)이던 것을 l.rarityLabel 로(요약 헤더와 일관, KO/JA 영문누수 제거). 검증: 신규 테스트 3종(빈 pathIDs 디코드 거부·currentID 폴백·systemDefault 유효), 게이트 140테스트·80.96% 통과, E2E 7/7, 클린 빌드. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
… 제거) Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
chattymin
added a commit
that referenced
this pull request
Aug 13, 2026
#156) The species grid reads names straight off `DexEntry.names`. That field is newer than the app, so entries saved before it exists decode to nil and every cell for them falls back to `#41`. The catch log has always repaired this — a row fetches its line once and writes the names back — but the grid is the screen you land on, so the repair now depends on visiting the other segment. `DexGridView` runs the same backfill on appear: stored entries are skipped (no fetch), and an offline attempt stores nothing so the next visit retries rather than freezing `#id` in. The grid also mixed permanent records with the companion you're raising, drawn identically. Species that are only there because of the active one are not records: buying an egg discards the active without touching `dex`, and a Ditto reveal replaces `pathIDs` wholesale, so cells and the species count drop with no explanation. `DexSpecies.isRaising` marks them with the same badge the catch log uses. It keys on whether the species has a graduation record, not on whether it belongs to the active one — raising a line you already graduated is secured, so it stays unmarked, and that branch is what the regression test pins. While moving the badge in, the number and shiny marks move from the sprite frame to the cell box. Anchored to the 44pt sprite they sat ~15pt inside a 80pt cell, which read as floating toward the middle; on the cell they sit at the edges and cover less of the pixel art. The badge needs `fixedSize()` for the same reason an overlay is offered its host's width, and without it "RAISING" wrapped.
8 of 10 tasks
9 of 15 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
출시 전 MVP 감사 반영
2렌즈 병렬 감사(정합성/robustness + UX/product/legal) 결과 중 launch-blocking·high 수정.
정합성 감사: BLOCKER 0, LAUNCH-READY. UX 감사: BLOCKER 1(언어) + HIGH 2. 전부 이 PR에서 처리.
AppLanguage.systemDefault(시스템 로케일 유추: ko/ja 외 en)를 신규 설치 기본값으로. 기존 사용자 저장 언어 불변pathIDs) →pathIDs[-1]크래시currentIDbaseID 폴백 + 디코드 시 빈 pathIDs 거부(→ 기본 알로 폴백)l.rarityLabel로 현지화(요약 헤더와 일관)감사가 확인한 출시 준비 완료 항목 (긍정)
미수정(의도)
lastErrorDescription는 provider usage 에러만 세팅되고 Claude 미사용은 nil 반환(에러 아님)이라 삼각형 안 뜸. 코드로 확인 후 미수정.검증
🤖 Generated with Claude Code