Skip to content

fix(collection): render shiny sprites for shiny species in Pokédex grid - #374

Merged
chattymin merged 1 commit into
chattymin:mainfrom
KillianHzr:fix/dex-grid-shiny-sprites
Oct 5, 2026
Merged

chattymin merged 1 commit into
chattymin:mainfrom
KillianHzr:fix/dex-grid-shiny-sprites

Conversation

@KillianHzr

Copy link
Copy Markdown
Contributor

Summary

In the collection's Pokédex grid view (DexGridView), species cells displayed normal sprites even when the species was owned as shiny. The shiny sprite was only displayed inside the individual detail page (PokemonDetailView) or momentarily when returning from it.

This happened because DexSpeciesCell gated shiny rendering on species.isShiny && isSelected. In older iterations of the Pokédex grid, tapping a cell selected it in place; once tapping was updated to open the full detail sheet, cells in the grid were never selected in place, leaving shiny species stuck on their normal sprites.

This change renders shiny sprites directly for collected shiny species in DexSpeciesCell (while still allowing individual normal/shiny appearance selection in the detail view), and adds automated rendering regression tests in DexColorRenderingTests.

Type of change

  • Bug fix
  • New feature
  • Refactor / cleanup
  • Documentation
  • Other:

UI changes

Before After
In the Pokédex grid view, owned shiny Pokémon showed a ✨ badge but their sprite was normal (non-shiny). Opening the detail view was required to see the shiny sprite. Owned shiny Pokémon in the Pokédex grid view directly display their shiny sprite matching their ✨ badge.

Checklist

  • swift build and swift test pass locally
  • PR title and description are written in English
  • UI changes are described above (before/after — images optional)
  • No copyrighted assets, secrets, or private tooling references are committed (see CONTRIBUTING)
  • Tests were added or updated for this change (DexColorRenderingTests.testPokedexGridRendersShinySpeciesColor)

@chattymin
chattymin merged commit 5214b04 into chattymin:main Oct 5, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants