Repository navigation
fix(collection): render shiny sprites for shiny species in Pokédex grid - #374
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
In the collection's Pokédex grid view (
DexGridView), species cells displayed normal sprites even when the species was owned as shiny. The shiny sprite was only displayed inside the individual detail page (PokemonDetailView) or momentarily when returning from it.This happened because
DexSpeciesCellgated shiny rendering onspecies.isShiny && isSelected. In older iterations of the Pokédex grid, tapping a cell selected it in place; once tapping was updated to open the full detail sheet, cells in the grid were never selected in place, leaving shiny species stuck on their normal sprites.This change renders shiny sprites directly for collected shiny species in
DexSpeciesCell(while still allowing individual normal/shiny appearance selection in the detail view), and adds automated rendering regression tests inDexColorRenderingTests.Type of change
UI changes
Checklist
swift buildandswift testpass locallyDexColorRenderingTests.testPokedexGridRendersShinySpeciesColor)