Repository navigation
feat: show exact usage in recap chart tooltips - #368
Merged
Merged
Conversation
LuceteYang
added a commit
to LuceteYang/PikaTokenBar
that referenced
this pull request
Oct 6, 2026
… for 1.10.0 - READMEs (en/ko/ja): the daily trend stacks by tool with a named legend (chattymin#348); "Also in the box" gains the menu bar right-click menu (chattymin#373), bulk shop purchases and the empty-Bag shop shortcut (chattymin#371, chattymin#366), type badges, wheel paging and sprite-to-entry (chattymin#391, chattymin#393, chattymin#394), exact numbers on hover (chattymin#392, chattymin#368), and the Russian UI (chattymin#372) - Daily trend shots render three tools stacked; pace and recap shots redrawn - Settings shots: labeled difficulty slider ends (chattymin#398) and the menu bar percent-color row; footer bumped to 1.10.0 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
8 of 10 tasks
donky-ey
pushed a commit
to donky-ey/PokeDexBar
that referenced
this pull request
Oct 15, 2026
Hovering a recap bar shows the same sentence VoiceOver reads: exact grouped tokens, a real zero, or 'no data' for days before recording.
Strongorange
added a commit
to Strongorange/PokeTokenBar-windows
that referenced
this pull request
Oct 19, 2026
Port macOS chattymin#332 core: UsageLedger keeps day-by-day totals across months with monotonic-max merges (a rotated log cannot erase a day that really happened) and covered-since semantics that separate a real zero from an unrecorded day. RecapPeriod models whole calendar weeks/months/years — weeks start on Sunday, the same rule as the week totals and the year heatmap grid, exposed as one named culture so all three switch together. UsageRecap.Make computes buckets (days, or months in the year view), totals, the same-days comparison for running periods, best day, streaks, active/counted days, in-period graduations and the canGoBack bound. Recap strings ported for the seven app languages (chattymin#367/chattymin#368 included).
Strongorange
added a commit
to Strongorange/PokeTokenBar-windows
that referenced
this pull request
Oct 19, 2026
The refresh background path merges the 365-day series into the ledger (single-flight serialized, mutated under the service gate; the recap reads a copy), prunes to this year plus last year for the year-over-year comparison, and writes usage-ledger.json atomically only when the merge changed anything. A corrupt ledger is moved to .corrupt and recording starts fresh. RecapQuery turns a ledger snapshot into the window's view model: period titles and bucket labels per scope and language, the chattymin#368 tooltips (exact tokens / a real zero / no data), the same-days compare note, current-period label (chattymin#367), stats lines and in-period graduates.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add native macOS hover tooltips to the usage recap chart, covering each bucket's meter and label. Reuse the existing accessibility description so the selected language, exact grouped token count, and date/month name stay consistent with VoiceOver. Known zero usage remains
0; future or unrecorded buckets sayno datain the selected language.Type of change
UI changes
The chart layout and existing accessibility labels are unchanged.
Native SwiftUI/AppKit captures with isolated fixture data. The after image shows the actual macOS tooltip over September 17, a known zero-usage day.
Validation
GitHub CI passed: build, test + coverage gate, and secret scan. The suite ran 1,381 tests with 14 skipped and zero failures, including the new regression test.
swift buildpassed locally.In a native SwiftUI/AppKit host with an isolated save and UserDefaults suite, inspected the actual bucket accessibility help and triggered the native macOS tooltip panel with a hover event.
Native accessibility help checks passed all 21 language/scope combinations, including exact positive counts, known zero, and no-data labels.
Added tests for positive usage, known zero, future/unrecorded buckets, yearly month labels, and all seven languages across Week/Month/Year.
./scripts/test-gate.shwas attempted but this Mac's Command Line Tools cannot importXCTest; CI must run the full suite.git diff --checkpassed.Checklist
swift buildandswift testpass locally