Repository navigation
docs: capture the whole-file read class and a guard-reachability check - #192
Merged
Merged
Conversation
#184 moved Codex rollout parsing to a chunked FileHandle stream. The class behind it lived only in that PR description, including which providers still read whole files and why converting them is deferred. Record it in the defect log with the two mechanics that make the streaming version work: splitting on the 0x0A byte, and a per-chunk autorelease boundary. Note that the regression guard is opt-in and does not run in CI. Also add a step to the defect protocol: confirm a scenario is reachable before adding or requesting a guard for it. Injection proves a guard works; it does not prove the situation can occur.
lukemonaghan
pushed a commit
to lukemonaghan/PokeTokenBar
that referenced
this pull request
Aug 24, 2026
chattymin#192) chattymin#184 moved Codex rollout parsing to a chunked FileHandle stream. The class behind it lived only in that PR description, including which providers still read whole files and why converting them is deferred. Record it in the defect log with the two mechanics that make the streaming version work: splitting on the 0x0A byte, and a per-chunk autorelease boundary. Note that the regression guard is opt-in and does not run in CI. Also add a step to the defect protocol: confirm a scenario is reachable before adding or requesting a guard for it. Injection proves a guard works; it does not prove the situation can occur.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two documentation changes, no source changes.
1. Record the whole-file read class (
docs/reference/defect-log.md).#184 moved Codex rollout parsing to a chunked
FileHandlestream. The class behindthat fix lived only in the PR description, which stops being reachable once the PR
scrolls out of view. The entry captures:
autoreleasepoolcannot release the source string;on the
0x0Abyte (safe because UTF-8 continuation bytes are all>= 0x80) and aper-chunk autorelease boundary;
boundary was missing, so that judgement should not be cited to rule streaming out;
parseClaudeFile,parseGrokFile,parseGeminiFile) and why converting them is deliberately deferred;2. Add a reachability step to the defect protocol (
CLAUDE.md).Before adding or requesting a guard, confirm the scenario can occur in this codebase.
Injecting a defect proves a guard works; it does not prove the situation is reachable.
The worked example is the #181 review, where a test was requested for Codex root
folding and then withdrawn: there is no
CODEX_HOME, so the roots are two hardcodedsiblings that cannot overlap, and the production callers are already normalized.
Type of change
UI changes
None.
Checklist
Validation
forEachCodexLine,parseClaudeFile,parseGrokFile,parseGeminiFile,CodexLargeRolloutPerformanceTests,POKETOKENBAR_RUN_LARGE_PERF.release build): peak RSS 416 -> 66 MiB, parse 14.25 -> 2.16 s, byte-identical entry
output before and after.