Repository navigation
fix: prevent repeated keychain prompts - #1
Merged
Merged
Conversation
LuceteYang
referenced
this pull request
in LuceteYang/PikaTokenBar
Aug 12, 2026
Narrowing the range surfaces two conditions that did not exist at 649: a species whose pre-evolution falls outside the range is itself a base candidate, and a chain whose root falls outside the range must be re-rooted before pruning or the whole line collapses. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
LuceteYang
referenced
this pull request
in LuceteYang/PikaTokenBar
Aug 12, 2026
A reader compared the 151-species banner against the "78 possible starts" line and understandably read it as a contradiction. All 151 Gen-1 species are still reachable through the evolution tree; 78 is just how many of them are valid *hatch* candidates (evolution-line base forms) — the other 73 are only reached by evolving. Spell that out instead of leaving "78" unexplained next to a "#1-151" banner. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
LuceteYang
referenced
this pull request
in LuceteYang/PikaTokenBar
Aug 12, 2026
The hatch-odds line said "78 possible starts" right next to the fork banner's "#1-151", which reads as a contradiction unless you already know 78 counts evolution-line base forms, not the full roster. Spell out that the other 73 species exist too — just reached by evolving, not hatching. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
LuceteYang
referenced
this pull request
in LuceteYang/PikaTokenBar
Aug 12, 2026
Narrowing the range surfaces two conditions that did not exist at 649: a species whose pre-evolution falls outside the range is itself a base candidate, and a chain whose root falls outside the range must be re-rooted before pruning or the whole line collapses. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
LuceteYang
referenced
this pull request
in LuceteYang/PikaTokenBar
Aug 12, 2026
The hatch-odds line said "78 possible starts" right next to the fork banner's "#1-151", which reads as a contradiction unless you already know 78 counts evolution-line base forms, not the full roster. Spell out that the other 73 species exist too — just reached by evolving, not hatching. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
KillianHzr
referenced
this pull request
in KillianHzr/PokeTokenLBI
Sep 17, 2026
…s catch boosts - Add type metadata and full species mapping for all 18 types across Gen 1-5 species (#1..649) - Add 18 Type Gym Badge achievements rewarded upon catching all species of that type - Add 18 Gym Badge passive items with official PokéAPI badge sprites (Kanto/Johto badges, Valerie's Fairy Badge, Piers' Dark Badge) - Implement cumulative +20% speed bonus (appearance rate and growth threshold) for species weak to owned badges - Support badge- prefix dynamic sprite downloading and caching in SpriteStore - Add full localization across all 7 supported languages - Add unit tests covering badge achievements, dual-type weakness calculations, and cumulative speed stacking - Document Type Gym Badges in README
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.