docs(docker): remove reference to nonexistent database-compose.yml#339
Merged
MoralCode merged 1 commit intoMay 26, 2026
Merged
Conversation
The file database-compose.yml no longer exists in the repository. The Docker Compose setup now includes the database service directly in docker-compose.yml. Closes #333 Signed-off-by: Suraj <surajh6705@gmail.com>
Contributor
|
Welcome to the project! Is there a reason this is marked as a draft? |
Author
|
Thank you for the quick review! Removing the draft status now — all CI checks should run shortly. |
Contributor
|
no problem! thanks for the PR You should also join CHAOSS Slack in the #wg-collectoss-8knot channel to chat with other maintainers/contributors, get notified when we have meetings, etc. |
Contributor
|
Docs build CI task completed. merging |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this solve?
Updates the docker-compose documentation to remove a reference to
database-compose.yml, a file that no longer exists in the repository. The Docker Compose setup now includes all services (including database) directly indocker-compose.yml, so runningdocker compose upis sufficient. Closes #333.What changed and why?
-f database-compose.ymlflag from the "with database container" example in docs/source/docker/docker-compose.rstdatabase-compose.ymlhas not existed for some time, making this reference misleading to contributorsHow was this tested?
docker-compose.ymlexists and contains the database service definitiondatabase-compose.ymlfile exists in the repositoryChecklist
make docsThis contribution was created with AI assistance, with human review and approval at each step.