Write documentation explaining the various types and standards of testing in the project#330
Merged
Conversation
Signed-off-by: Adrian Edwards <adredwar@redhat.com>
Signed-off-by: Adrian Edwards <adredwar@redhat.com>
Signed-off-by: Adrian Edwards <adredwar@redhat.com>
Signed-off-by: Adrian Edwards <adredwar@redhat.com>
|
This looks good to go. Well done @MoralCode. |
Contributor
Author
|
@nancywrites i dont see your comments. where did you leave them? |
MoralCode
added
the
waiting
Contributor
Author
|
Haven't heard anything in a week, so I'll merge this and any additional feedback can be brought as a followup PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This is a docs change to document testing relatively thoroughly.
It's somewhat high level but I think its much better than just relying on this living in my own head
Notes for Reviewers
Testing level necessary for this change: Sanity check + code review.
Would be nice to have someone else read the content and sign off, but given that this replaces the nothing that was there before, I wont make that a blocker for merge.
@cdolfi may find this interesting since there have also been some desires to improve 8Knot's testing approach recently as well.
Signed commits