[SSR Agent] Issue Fix (346): Fix IDE integration using pre-installed extension - #348
Open
joneba-google wants to merge 1 commit into
Open
[SSR Agent] Issue Fix (346): Fix IDE integration using pre-installed extension#348joneba-google wants to merge 1 commit into
joneba-google wants to merge 1 commit into
Conversation
|
📊 PR Size: size/M
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #346
Context & Problem
When a user accepts the IDE integration prompt in VS Code while the companion
extension is already installed/running, Gemini CLI unconditionally executes
/ide installrather than enabling the existing connection via/ide enable.This occurred because the
handleIdePromptCompletecallback insideAppContainer.tsxignored theisExtensionPreInstalledflag returned byIdeIntegrationNudgeand hardcoded/ide install.Detailed Changes
handleIdePromptCompletetoinspect
result.isExtensionPreInstalledwhen the user selection is'yes'.It now appropriately triggers
/ide enablewhen pre-installed, or falls backto
/ide installotherwise.evaluating both branches (
isExtensionPreInstalledastrueandfalse) toverify that the correct slash commands are processed.
Verification
The logic was statically verified and validated via the updated test suite in
packages/cli/src/ui/AppContainer.test.tsx.GitHub Issue: #346