[SSR Agent] Issue Fix (295): Trust Nix store paths in system path checks - #298
Open
joneba-google wants to merge 1 commit into
Open
joneba-google wants to merge 1 commit into
joneba-google wants to merge 1 commit into
Conversation
|
📊 PR Size: size/XS
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #295
Original Issue: #295
Context & Problem
In Nix and
devenvenvironments, standard tools like Ripgrep are typically located inside the/nix/storedirectory. When executing Gemini CLI in such environments, the file path check implementationisTrustedSystemPath()rejected the path to the Ripgrep executable as untrusted, leading to a fallback to a basic grep utility that hangs indefinitely on large codebases.Detailed Changes
/nix/storeto the POSIX trustedPrefixes array so that system executables residing under the Nix store are correctly recognized and allowed.isTrustedSystemPath()correctly resolves Nix store subdirectories (e.g.,/nix/store/abc123def456-ripgrep-14.1.0/bin/rg) totrue.Verification
packages/core/src/utils/paths.test.tsto confirm the newly added test case passes successfully.