[SSR Agent] Issue Fix (283): Update LLMResponse usageMetadata documentation - #284
Open
joneba-google wants to merge 1 commit into
Open
joneba-google wants to merge 1 commit into
joneba-google wants to merge 1 commit into
Conversation
|
📊 PR Size: size/S
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #283
Original issue: #283
Context & Problem
The hook reference documentation for
LLMResponse.usageMetadataincorrectly omittedpromptTokenCountandcandidatesTokenCount. This was due to incomplete documentation indocs/hooks/reference.mdrelative to the exportedLLMResponseinterface and the hook translator implementation inpackages/core/src/hooks/hookTranslator.ts.Detailed Changes
docs/hooks/reference.md: Updated theusageMetadataschema block underLLMResponseto explicitly documentpromptTokenCount,candidatesTokenCount, andtotalTokenCount.packages/core/src/hooks/hookTranslator.test.ts: Added a unit test to verify that converting hook responses back to the SDK format correctly preservesusageMetadatatoken counts (promptTokenCount,candidatesTokenCount, andtotalTokenCount).Verification
LLMResponseTypeScript interface.packages/core/src/hooks/hookTranslator.test.tshave been added to prevent regressions.