Make timestamp formatting consistent#6042
Merged
larsewi merged 1 commit intocfengine:masterfrom Feb 13, 2026
Merged
Conversation
craigcomstock
approved these changes
Feb 11, 2026
Contributor
Author
|
Fixed other similar warnings (although less serious) with the same change for consistency. |
larsewi
approved these changes
Feb 11, 2026
Contributor
|
@cf-bottom Jenkins please :) |
|
Alright, I triggered a build: Jenkins: https://ci.cfengine.com/job/pr-pipeline/13378/ Packages: http://buildcache.cfengine.com/packages/testing-pr/jenkins-pr-pipeline-13378/ |
Contributor
|
sequential-tests failure was a flake, looks good. |
craigcomstock
requested changes
Feb 12, 2026
Contributor
craigcomstock
left a comment
There was a problem hiding this comment.
@amousset please squash all commits into one or separate into issue fix and code quality fix.
A few cases did not use %jd + intmax_t. Make these consistent. Also prevents a segfault on ARMv7 when %lu was used.
9df1130 to
9420b69
Compare
Contributor
Author
|
Squashed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use
%jd+intmax_tto format the timestamp (like othertime_tformats do) in file backup code.On ARMv7 (which is, understandably, unsupported) it segfaults at runtime. But formatting a (signed)
time_tas unsigned is, AFAIK, undefined behavior annyway.