ENT-12619: Suppress stderr from expected-failure commands #2113
+5
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cleanup commands in prepare-testmachine-chroot (fuser, umount) may fail when there is nothing to kill or unmount, producing confusing error output in Jenkins logs. Redirect their output to /dev/null, matching the pattern already used in test-on-testmachine lines 94 and 96. Also suppress stdout/stderr from ps|grep process checks in test-on-testmachine that look for known benign processes (minilogd, gpg-agent). We only care about the exit code, not the output, so use grep -q and redirect ps stderr. Ticket: ENT-12619 Signed-off-by: Lars Erik Wik <lars.erik.wik@northern.tech> Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
craigcomstock
approved these changes
Feb 12, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
fuser -kandumountcleanup commands inprepare-testmachine-chrootthat may fail when there is nothing to kill/unmount, matching the pattern already used intest-on-testmachinelines 94 and 96grep -qand redirectpsstderr intest-on-testmachineprocess checks for known benign processes (minilogd, gpg-agent) since we only care about the exit codeTicket: ENT-12619
🤖 Generated with Claude Code