fix: error on illegal page size - #662
Merged
Merged
Conversation
Thomas Harning Jr (harningt)
approved these changes
Oct 24, 2024
Contributor
|
Bet it wants you to break up that line :( |
Thomas Harning Jr (harningt)
previously requested changes
Oct 24, 2024
Thomas Harning Jr (harningt)
left a comment
Thomas Harning Jr (harningt)
left a comment
Contributor
There was a problem hiding this comment.
poetry black censys/ made the suggested fix I presented
Co-authored-by: Thomas Harning Jr <thomas@censys.io>
Contributor
Author
|
I think I need another test based on the 100% requirement of the last failure |
Andrew Alexander (andrewalexander)
requested a review
from Aidan Holland (thehappydinoa)
January 10, 2025 23:41
Andrew Alexander (andrewalexander)
dismissed
Thomas Harning Jr (harningt)’s stale review
January 16, 2025 21:12
it was incorporated
Andrew Alexander (andrewalexander)
requested a review
from Thomas Harning Jr (harningt)
January 16, 2025 21:12
Justin Bastress (justinbastress)
approved these changes
Jan 16, 2025
Thomas Harning Jr (harningt)
approved these changes
Jan 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds an error if a page size greater than the API's maximum of 1000 is entered. It also includes a message instructing users to use
--pages -1to fetch all pages in the event they hit this error.Updated 2025-01-10:
Updated the dependencies per all the other open dependabot PRs; added the same check/warning for the execute-saved-query-by-id variant (done before we execute the saved query); and added tests for both places to maintain 100% coverage