Skip to content

T3 Code clone: refresh settings pages and connection actions - #738

Merged
daehyeon-mun merged 4 commits into
daehyeon/t3-code-mainfrom
daehyeon/t3-up-settings-pages
Oct 18, 2026
Merged

daehyeon-mun merged 4 commits into
daehyeon/t3-code-mainfrom
daehyeon/t3-up-settings-pages

Conversation

@daehyeon-mun

@daehyeon-mun daehyeon-mun commented Oct 18, 2026 •

Copy link
Copy Markdown
Collaborator

Settings now group keybindings by area, keep defaults visible while disconnected, and warn when an older environment accepts a save but silently drops the changed setting. Connections can copy an MCP URL, General links to the mobile stores with QR popovers, and onboarding skips selected computers that are offline or switched off.

The page toolbar, provider add row, common page widths, semantic branch hint, themed setup panels, project path truncation, device-host glyph baseline and pooled-usage pace alignment follow T3 Code 9c161462c9. Picking an editor in the details dropdown changes the preference; the adjacent Open action launches it.

Acceptance Result Proof
Grouped keybindings, disconnected defaults/read-only notice, Focus URL label, thread details shortcut, model-picker jump precedence Implemented; focused tests pass keybinding tests
Cmd+F focuses settings search; Update track is searchable Implemented; focused tests and native Meta+F/search drive passed search tests
Unsupported saves warn and preserve per-environment outcomes Implemented; dropped toggle/text/project/nested keys and unchanged values tested scoped-save tests
Provider add row, widths, wizard backgrounds, semantic status and branch prefix Implemented; focused tests and native bundle passed settings implementation
MCP URL follows the connected direct route, falls back through saved routes, skips SSH Implemented; HTTP, HTTPS, active-route precedence and clipboard tested connections tests
Mobile app store QR row on both tracks Implemented; store URLs/QR tested and final-head store popover captured mobile tests
Onboarding skips offline/switched-off computers, explains imports, keeps path names visible Implemented; skip and Unix/Windows path cases pass onboarding tests
Editor dropdown changes preference without opening a folder Implemented; preference-only action sends no editor RPC shell tests
Local environment switch while off; provider Runtime controls; wizard width stability Already present: Connections always mounts ThisMachineSection, Runtime receives its row container width, wizard panel scrolls inside a fixed-width dialog Connections, Runtime

Upstream changes followed:

f36df18524 pingdotgg/t3code#16273 backs off a secondary desktop bootstrap topology poll. This client has no secondary desktop registration poll: its sole primary bootstrap exchanges once when its server becomes ready (T3LocalBackend.swift exchange). There is no repeated credential polling path to port or suppress here.

Validation:

  • Bun 1.4.2 frozen install and source generation passed.
  • 883 focused settings/pages/connections/shell tests passed, plus all 4 onboarding-pairing cases after the offline case was added.
  • Strict app TypeScript and staged caps passed.
  • Initial full Bun run: 5268 pass, 3 failures. The two timeouts passed with a 60-second budget (204 rerun cases plus 27 grammar cases), and the stale beta-popover inventory was corrected and passed. The final obsolete-toast removal passed 25 shell/details cases.
  • Embedded server archive staged offline and verified against the unchanged pin, SHA256SUMS and Mach-O signatures. Terminal host build passed.
  • Final macOS bundle at 36ec227a37 passed (Rust bake 557s, Swift 2.9s); app data Cargo tests 25/25 passed. Integration was merged at 20225a341d (including runtime permission notices and Off/Reconnecting labels), and the rendered keybinding fixture now supplies grouped rows. On that frozen head, 1148 affected Bun cases, strict TypeScript, and the full53 Cargo lib tests (data25 + macOS28) passed.
  • Native drive at 1280×840 confirmed grouped defaults without a connected environment and delivered Meta+F from the keybindings field into Settings search. The “update track” query returned the correct result. Window-server screenshots were visually inspected.

Before and after grouped default keybindings

Settings search after Meta+F

Dropped-setting proof used the same request {enableAgentDeviceAccess:true} and reply {enableAgentDeviceAccess:false}: before, one successful save and no notice; after, zero successful saves and “Setting not saved,” naming the unsupported environment and requesting its update. Recorded comparison and live search proof.

Native General → Mobile app was captured at product head 36ec227a37 by the coordinator after the search-filtered route selector ended the first batch. The platform tap path and window image were inspected: Google Play QR/store link is present and the stale beta warning is gone.

Before and after mobile store links

No evidence is committed. Native screenshots use window-server capture because default Metal cache snapshots can be transparent.

Prepared with Codex; continues work begun in the prior Claude session.

daehyeon-mun and others added 2 commits October 18, 2026 23:19
Group keybindings by area, report settings an older environment drops, and add MCP URL and mobile store actions. Keep onboarding usable with offline computers and align the scoped settings polish with T3 Code 9c161462c9.

Co-Authored-By: Codex <noreply@openai.com>
Co-Authored-By: Codex <noreply@openai.com>
@daehyeon-mun

Copy link
Copy Markdown
Collaborator Author

Native Settings at 1280×840: disconnected environments now retain grouped default keybindings and the grouped toolbar. The final build also removes the obsolete beta warning.

Before and after keybindings

@daehyeon-mun

Copy link
Copy Markdown
Collaborator Author

Final macOS head36ec227a37: the driver delivered Meta+F from the keybindings field, then Settings search returned “Update track.” Window capture is attached.

Dropped-setting verification used the same request and server reply before and after:

{"request":{"enableAgentDeviceAccess":true},"response":{"enableAgentDeviceAccess":false}}

Before: savedEnvironmentCount: 1, no notice. After: savedEnvironmentCount: 0, error notice “Setting not saved,” naming Old server and explaining that it must update to support the setting. The reproducible comparison is kept under ignored target/evidence/scoped-save-comparison.json.

Settings search after Meta+F

@daehyeon-mun

Copy link
Copy Markdown
Collaborator Author

Native General → Mobile app at 1280×840: the obsolete two-step beta links and warning are replaced by the final upstream Google Play QR and store link. Final-head capture completed by the coordinator using the same platform tap path.

Before and after mobile store links

daehyeon-mun and others added 2 commits October 19, 2026 00:01
Co-Authored-By: Codex <noreply@openai.com>
@daehyeon-mun
daehyeon-mun marked this pull request as ready for review October 18, 2026 15:17
@daehyeon-mun
daehyeon-mun merged commit aeb0f9a into daehyeon/t3-code-main Oct 18, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant