feat: update @svta/cml-cmcd to 2.4.0 - [Claude Code]

[littlespex]

Summary

Upgrades @svta/cml-cmcd from 2.3.2 to ^2.4.0 and adapts dash.js to the new CmcdReporter semantics. The headline change in 2.4.0: update() auto-fires the corresponding state-change event when a tracked field changes, and a follow-up recordEvent() for the same event is dedup-suppressed — silently dropping its data argument.

The existing dash.js pattern hit this footgun in _onPlaybackStateChange: update({sta}) then recordEvent('ps', cmcdData) was silently losing bl, mtp, pt, ltc, msd enrichment under 2.4.0. This PR consolidates that into a single update({ ...continuousMetrics, sta }) call so the auto-fire emits the full payload. It also splits state-change vs non-state event paths cleanly, adds throttled pt tracking via PLAYBACK_TIME_UPDATED, and replaces the local CmcdRequestCollector functional-test helper with the library's new CmcdReportRecorder.

What changed

• package.json — bump @svta/cml-cmcd 2.3.2 → ^2.4.0 and @svta/cml-request 1.0.12 → 1.0.13 (peer-dep alignment).
• src/streaming/controllers/CmcdController.js:
  • Add _gatherContinuousMetrics() helper as the single source of truth for fields pulled from CmcdModel.
  • Refactor _onPlaybackStateChange to a single consolidated update({ ..._gatherContinuousMetrics(), sta: state }) call. This is the dedup-footgun fix.
  • Rename triggerCmcdEventMode → _recordNonStateEvent. Continuous metrics flow through update(); only ephemeral per-event payload (e.g., ec) rides recordEvent()'s data arg.
  • _onPlayerError now passes { ec: [String(code)] } (array form per CTA-5004-B / the 2.4.0 Cmcd.ec type).
  • _handleResponseReceived now also uses _gatherContinuousMetrics() — continuous metrics persist into the store via update(), only ephemeral CMSD-derived data rides recordResponseReceived()'s data arg.
  • Add throttled _onPlaybackTimeUpdated listener (4 Hz; validates e.time is a finite non-negative number) that writes pt directly to the reporter's persistent store. Subscribed in _initializeEventBus, unsubscribed in reset, state reset in _resetInitialSettings.
• test/unit/test/streaming/streaming.controllers.CmcdController.js — new tests: pt lands in event payload after listener fires; throttle suppresses second fire within window; invalid e.time values are ignored; PLAY_STATE event includes ltc+pt enrichment (regression test for the footgun); ERROR event carries ec as string[].
• test/functional/test/feature-support/cmcd-v2.js — migrated from local CmcdRequestCollector to CmcdReportRecorder from @svta/cml-cmcd. Single attach-level waitTimeout replaces per-call timeouts. Added end-to-end assertion that PLAY_STATE event reports carry ≥2 continuous-metric enrichment fields (pt/bl/mtp).
• test/functional/helpers/CmcdRequestCollector.js — deleted (superseded).
• githook.cjs — fixed the prepare script's hook installer to resolve the actual git hooks directory when .git is a worktree file (was failing with ENOTDIR in worktrees).

Design and plan

• Design spec: docs/superpowers/specs/2026-05-27-cmcd-v2.4-update-design.md
• Implementation plan: docs/superpowers/plans/2026-05-27-cmcd-v2.4-update.md

Behavior deltas to be aware of

1. PLAYBACK_RATE auto-fire is new. Under 2.4.0, update(prData) in _onPlaybackRateChanged now auto-fires a PLAYBACK_RATE event-mode report when an event target subscribes to the pr event. This is correct per CTA-5004-B but is a visible behavior change for event-target consumers that weren't previously receiving PLAYBACK_RATE events.
2. ec shape change. ERROR event payloads now carry ec as string[] (was a scalar). Required by 2.4.0 typings and CTA-5004-B's list notation. Downstream CMCD event validators parsing error payloads should accept array form.
3. pt is now emitted in event-mode reports. Previously not reported by dash.js at all; now flows into the persistent store at 4 Hz from PLAYBACK_TIME_UPDATED.
4. Stubbed event-target POST status code shifts 200 → 204. Transparent to consumers because HTTPLoader already treats any 2xx as success.

Test Plan

• npm run lint — clean
• npm test — 3670 passing, 0 failing (+12 new unit tests in this branch)
• npm run test-functional — exit 0 (CMCD-specific: Query 7/8 with pre-existing unrelated flake, Header 6/6, Event 10/10, Key Filtering 6/6, Version 6/6)
• npm run build — modern + legacy both clean
• Spot-check samples/cmcd/cmcd-v2.html in a browser: PLAY_STATE event report shows sta, pt, bl, mtp; playback rate change triggers a pr event report
• Confirm manifest/segment requests still carry monotonically-increasing sn (now reporter-internal)

🤖 Generated with Claude Code

[Copilot]

Pull request overview

This PR upgrades CMCD reporting to @svta/cml-cmcd 2.4.0 and adapts dash.js event-mode reporting to the library’s new update() auto-fire semantics.

Changes:

• Refactors CmcdController to consolidate PLAY_STATE updates, add throttled pt tracking, and separate state-change from non-state event reporting.
• Migrates CMCD v2 functional tests from the local request collector to CmcdReportRecorder and adds regression coverage for enriched event payloads.
• Bumps CMCD-related dependencies and adjusts the git hook installer for worktree .git files.

Reviewed changes

Copilot reviewed 8 out of 9 changed files in this pull request and generated 3 comments.

Show a summary per file

File	Description
src/streaming/controllers/CmcdController.js	Updates CMCD event/reporting logic for 2.4.0 semantics and adds pt listener support.
test/unit/test/streaming/streaming.controllers.CmcdController.js	Adds unit coverage for pt, PLAY_STATE enrichment, throttling, invalid times, and ERROR ec shape.
test/functional/test/feature-support/cmcd-v2.js	Migrates functional CMCD v2 tests to CmcdReportRecorder and adds event enrichment assertions.
test/functional/helpers/CmcdRequestCollector.js	Removes the now-superseded local functional-test collector helper.
package.json	Updates @svta/cml-cmcd and @svta/cml-request dependency versions.
package-lock.json	Locks the updated dependency versions.
githook.cjs	Attempts to resolve the actual git hooks directory for worktree checkouts.
docs/superpowers/specs/2026-05-27-cmcd-v2.4-update-design.md	Adds the implementation design for the CMCD 2.4.0 upgrade.
docs/superpowers/plans/2026-05-27-cmcd-v2.4-update.md	Adds the task-by-task implementation plan for the CMCD 2.4.0 upgrade.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.