Skip to content

IB_DESIGNABLE Support#57

Merged
cbess merged 9 commits intocbess:ib-updatefrom
vincentneo:IB_DESIGNABLE
Sep 20, 2019
Merged

IB_DESIGNABLE Support#57
cbess merged 9 commits intocbess:ib-updatefrom
vincentneo:IB_DESIGNABLE

Conversation

@vincentneo
Copy link

@vincentneo vincentneo commented Dec 1, 2016

IB_DESIGNABLE basic support with placeholder text viewable in storyboard.

@vincentneo
IB_DESIGNABLE Support
a6660bb 
IB_DESIGNABLE basic support with placeholder text viewable in storyboard.
@vincentneo
Options can be added via storyboard
54b94fd 
Label, Text Color and Text Shadow Color can be customised using the storyboard.
Default Label Text is "AutoScrollLabel"
@vincentneo
Oops, Mistakes!
2c2c597
@vincentneo
Oops, Mistakes!
9ed4d26
@vincentneo
Options can be added via Storyboard (re-commit)
ad12ecb 
Label, Text Color and Text Shadow Color can be customised using the storyboard.
Default Label Text is "AutoScrollLabel"
@cbess
Copy link
Owner

cbess commented Dec 3, 2016

Thanks for updating it

@Panajev
Copy link

Panajev commented May 4, 2017

@vincentneo can you please solve the merge conflict? It looks like a really cool addition! @cbess would you merge it once the conflicts have been solved?

@vincentneo
Copy link
Author

vincentneo commented May 4, 2017

@

@vincentneo vincentneo closed this May 4, 2017
@vincentneo vincentneo reopened this May 4, 2017
@vincentneo
Copy link
Author

vincentneo commented May 4, 2017

Pressed the wrong thing sorry! @Panajev sure, when I am free!

@vincentneo
Attempt to fix conflict
2c0e598 
Probably won't work
@vincentneo
Copy link
Author

vincentneo commented May 4, 2017

@Panajev Tried, but I do not know how to resolve. Really bad at Git stuff so yeah. Would be great if you could help!

@cbess
Copy link
Owner

cbess commented May 4, 2017

I can merge it once you resolve the code review comments.

@vincentneo
Copy link
Author

vincentneo commented May 4, 2017

@cbess sure. I'll try

@vincentneo
Copy link
Author

vincentneo commented May 5, 2017

@Panajev @cbess I fixed conflicts! Didn't know it was as easy as deleting the red stuff

@vincentneo
Added Fade Length & Shadow Offset
22c460b 
Now I have added Fade Length & Shadow Offset to have IBInspectable support as well.
@Panajev
Copy link

Panajev commented May 5, 2017 via email

cbess
cbess reviewed May 5, 2017
View reviewed changes
CBAutoScrollLabel/CBAutoScrollLabel.m
label.autoresizingMask = self.autoresizingMask;

// Placeholder text for IB_DESIGNABLE in Storyboards
label.text = @"AutoScrollLabel";
Copy link
Owner

@cbess cbess Dec 3, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you think it would be best to move this to prepareForInterfaceBuilder so that we don't unnecessarily exec this logic during runtime?

Copy link
Author

@vincentneo vincentneo May 5, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, maybe it would be better. It would definitely look better too.

CBAutoScrollLabel/CBAutoScrollLabel.m

@end

IB_DESIGNABLE
Copy link
Owner

@cbess cbess Dec 3, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please place a space above this line to make it easier to distinguish the separation of the blocks.

Copy link
Author

@vincentneo vincentneo May 5, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok. I'll do it tomorrow. (It's eleven here)

CBAutoScrollLabel/CBAutoScrollLabel.m Outdated
self.fadeLength = kDefaultFadeLength;
}


Copy link
Owner

@cbess cbess Dec 3, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove this space as it doesn't appear to add any value

Copy link
Author

@vincentneo vincentneo May 5, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same thing, tomorrow.

@vincentneo
Copy link
Author

vincentneo commented May 6, 2017 •
edited
Loading

I have tried prepareForInterfaceBuilder but it seems like the label will be stuck there in storyboard, and changing the text property doesn't change anything.
Have i done something wrong? I am not that good at Objective-C.

-(void)prepareForInterfaceBuilder {
    // Placeholder text for IB_DESIGNABLE in Storyboards
    self.mainLabel.text = @"AutoScrollLabel";
}

@vincentneo
Copy link
Author

vincentneo commented May 7, 2017

@cbess is there any problems now?

@cbess
Copy link
Owner

cbess commented Sep 20, 2019

@vincentneo thanks for these changes. I'm reviewing it now to merge it. Sorry, for the very long delay :|

@cbess cbess changed the base branch from master to ib-update September 20, 2019 18:30
@cbess cbess merged commit b6656a0 into cbess:ib-update Sep 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cbess cbess cbess left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@vincentneo @cbess @Panajev