Conversation
This was referenced Jul 9, 2025
apiology
marked this pull request as draft
July 9, 2025 20:29
Drop rubygems as rbs collection won't let us shim core
apiology
marked this pull request as ready for review
July 12, 2025 15:51
apiology
commented
Jul 12, 2025
| s.add_runtime_dependency 'logger', '~> 1.6' | ||
| s.add_runtime_dependency 'observer', '~> 0.1' | ||
| s.add_runtime_dependency 'ostruct', '~> 0.6' | ||
| s.add_runtime_dependency 'open3', '~> 0.2.1' |
Contributor
Author
There was a problem hiding this comment.
These are part of stdlib, but rbs collection wants to see an explicit dependency in order to recognize that it should look for shims in my configured source for them.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.