Skip to content

[Bug fix] Fixed an error in rbs/fills/tuple.rbs - #993

Merged
castwide merged 3 commits into
castwide:masterfrom
TD12734:hotfix/rbs_error
Jul 9, 2025
Merged

castwide merged 3 commits into
castwide:masterfrom
TD12734:hotfix/rbs_error

Conversation

@TD12734

@TD12734 TD12734 commented Jul 4, 2025

Copy link
Copy Markdown
Contributor

When using Solargraph version 0.55.4 or later with vscode on Windows, I get the following error:

error

If this error occurs, various functions of solargraph will not work.

The cause of the error is that when the rbs gem is a relatively old version (for example, 3.4.0), an error occurs in the syntax of rbs/fills/tuple.rbs.

To avoid this, we have made it mandatory to also install the rbs gem of version 3.6.1 or higher when installing the solargraph gem.

The value 3.6.1 is the version in which the error no longer occurred in my environment.

@apiology

apiology commented Jul 4, 2025

Copy link
Copy Markdown
Contributor

Hmmm, unfortunately requiring a newer rbs gem will eliminate support for Ruby 3.0.

We could probably work around it in some way so that LSP support in Ruby 3.0 can work again.

@TD12734

TD12734 commented Jul 5, 2025

Copy link
Copy Markdown
Contributor Author

@apiology

Thank you for your review.
The rbs version specification has been corrected to 3.6.1 or higher and less than 3.7.0.
If it is 3.6.1, it can be used with Ruby 3.0.
https://rubygems.org/gems/rbs/versions/3.6.1

@TD12734

TD12734 commented Jul 5, 2025

Copy link
Copy Markdown
Contributor Author

I have also confirmed that solargraph works with rbs3.6.1.

@apiology

apiology commented Jul 5, 2025

Copy link
Copy Markdown
Contributor

Excellent! Maybe our Ruby 3.0 CI tests worked because it was using a new version - was confused on that point.

@apiology

apiology commented Jul 5, 2025

Copy link
Copy Markdown
Contributor

Yay--I was able to reproduce the issue here: https://github.com/castwide/solargraph/actions/runs/16091976403/job/45409964842?pr=995

@castwide

castwide commented Jul 9, 2025

Copy link
Copy Markdown
Owner

Thanks! This is likely to be superceded by #995, but I'm happy to iterate through changes before the next release.

@castwide
castwide merged commit 444be81 into castwide:master Jul 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants