[regression] Gem caching perf and logging fixes - #983
Merged
Conversation
apiology
commented
Jun 29, 2025
apiology
commented
Contributor
- [regression] Only log when we are actually doing work caching pins
- [regression] Fix misspelled mutex-y variable name in gem caching - probably fixes Workplace scan over-forking #976
- [regression] Speed up 'solargraph gems' caching by only loading api_map once, avoiding extra loading of files from disk
- [regression] Use existing pattern to keep only one cache of combined pins in memory, instead of one per DocMap (~0.25s speed-up in solargraph project per docmap on my computer, ymmv)
* [regression] Only log when we are actually doing work caching pins * [regression] Fix misspelled mutex-y variable name in gem caching - probably fixes castwide#976 * [regression] Speed up 'solargraph gems' caching by only loading api_map once, avoiding extra loading of files from disk * [regression] Use existing pattern to keep only one cache of combined pins in memory, instead of one per DocMap (~0.25s speed-up in solargraph project per docmap on my computer, ymmv)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.